Replace manual untagging of smi with proper Smi methods

Replace manual untagging of smi with proper Smi methods

R=vegorov@google.com, zra@google.com

Committed: https://github.com/dart-lang/sdk/commit/f685e4a8dd24418861fe25cd6f05014c41ef9319

[alexmarkov, 2017-07-12 16:45:31]

alexmarkov@google.com changed reviewers:
+ asiva@google.com, regis@google.com, vegorov@google.com, zra@google.com

[zra, 2017-07-12 16:47:12]

lgtm

[Vyacheslav Egorov (Google), 2017-07-12 16:56:27]

LGTM!

Thanks.

https://codereview.chromium.org/2975073002/diff/1/runtime/vm/intermediate_lan...
File runtime/vm/intermediate_language_arm.cc (left):

https://codereview.chromium.org/2975073002/diff/1/runtime/vm/intermediate_lan...
runtime/vm/intermediate_language_arm.cc:6546:
ASSERT(locs()->in(1).constant().IsSmi());
I think this ASSERT can be deleted because Smi::Cast(...) contains the same
assert.

[alexmarkov, 2017-07-12 17:37:37]

https://codereview.chromium.org/2975073002/diff/1/runtime/vm/intermediate_lan...
File runtime/vm/intermediate_language_arm.cc (left):

https://codereview.chromium.org/2975073002/diff/1/runtime/vm/intermediate_lan...
runtime/vm/intermediate_language_arm.cc:6546:
ASSERT(locs()->in(1).constant().IsSmi());
On 2017/07/12 16:56:27, Vyacheslav Egorov (Google) wrote:
> I think this ASSERT can be deleted because Smi::Cast(...) contains the same
> assert.

You are right, it can be deleted. However, I think the explicit ASSERT makes
this code a little bit more readable. Also, it is more convenient to get an
assertion failure message at a more specific place rather than inside generic
Smi::Cast() which is called from many other places.

So I would prefer to leave it here, if you don't mind.

[alexmarkov, 2017-07-12 17:38:01]

Description was changed from

==========
Replace manual untagging of smi with proper Smi methods
==========

to

==========
Replace manual untagging of smi with proper Smi methods

R=vegorov@google.com, zra@google.com

Committed:
https://github.com/dart-lang/sdk/commit/f685e4a8dd24418861fe25cd6f05014c41ef9319
==========

[alexmarkov, 2017-07-12 17:38:03]

Committed patchset #1 (id:1) manually as
f685e4a8dd24418861fe25cd6f05014c41ef9319 (presubmit successful).