Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issue 2975063003: [Merge M60] Fix shelf dragging context in case Context Menu is shown. (Closed)

Created:
3 years, 5 months ago by khmel
Modified:
3 years, 5 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3112
Project:
chromium
Visibility:
Public.

Description

[Merge M60] Fix shelf dragging context in case Context Menu is shown. In case context menu is shown for the shelf button it prevents next mouse released events. Not handling this event leaves shelf view in incorrect state when dragging target is set for the button used to show the context menu. This CL manually released mouse caputure in this case. TEST=Manually on device + browser test. BUG=737407 TBR=msw@chromium.org NOTRY=true NOPRESUBMIT=true Change-Id: I32ac29b26300efba388cb09ecb5717ecd0de2001 Reviewed-on: https://chromium-review.googlesource.com/559829 Commit-Queue: Yury Khmel <khmel@google.com>; Reviewed-by: Michael Wasserman <msw@chromium.org>; Cr-Original-Commit-Position: refs/heads/master@{#484387} (cherry picked from commit b555e5e2e711754168e8603c4291d443bae51250) Review-Url: https://codereview.chromium.org/2975063003 Cr-Commit-Position: refs/branch-heads/3112@{#597} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/a146c77d0a3ecdb0dce7bd2d3048c4d61df273d2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -2 lines) Patch
M ash/shelf/shelf_button.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M ash/shelf/shelf_view.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc View 1 chunk +31 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (5 generated)
khmel
3 years, 5 months ago (2017-07-12 17:59:19 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2975063003/1
3 years, 5 months ago (2017-07-12 18:57:31 UTC) #5
commit-bot: I haz the power
3 years, 5 months ago (2017-07-12 18:58:14 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a146c77d0a3ecdb0dce7bd2d3048...

Powered by Google App Engine
This is Rietveld 408576698