Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(826)

Issue 2974983002: Remove all calls to domAutomationController.setAutomationId. (Closed)

Created:
3 years, 5 months ago by Łukasz Anforowicz
Modified:
3 years, 5 months ago
Reviewers:
sky
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove all calls to domAutomationController.setAutomationId. These calls are no longer needed after r485461 (https://crrev.com/2478803003) which has made the domAutomationController.setAutomationId call a no-op. BUG=662543 This CL was uploaded by git cl split. R=thakis@chromium.org Review-Url: https://codereview.chromium.org/2974983002 Cr-Commit-Position: refs/heads/master@{#485978} Committed: https://chromium.googlesource.com/chromium/src/+/69865754e32f123cc290989423647504c4aa86c2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M chrome/browser/chrome_service_worker_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
Łukasz Anforowicz
sky@, can you PTAL?
3 years, 5 months ago (2017-07-11 23:49:48 UTC) #4
sky
LGTM
3 years, 5 months ago (2017-07-12 15:33:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2974983002/1
3 years, 5 months ago (2017-07-12 15:51:14 UTC) #9
commit-bot: I haz the power
3 years, 5 months ago (2017-07-12 15:56:41 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/69865754e32f123cc29098942364...

Powered by Google App Engine
This is Rietveld 408576698