Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 2974923002: Revert of Remove all of the CrOS Ozone configs from MB. (Closed)

Created:
3 years, 5 months ago by keishi
Modified:
3 years, 5 months ago
CC:
chromium-reviews, shinyak+cc_chromium.com, tikuta+cc_chromium.com, ukai+cc_chromium.com, yyanagisawa+cc_chromium.com, jonross
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove all of the CrOS Ozone configs from MB. (patchset #8 id:130001 of https://codereview.chromium.org/2949093004/ ) Reason for revert: ash_unittests are failing on ChromeOS AsanLsan bot crbug.com/740859 Regression range is 485493 - 485513 so suspecting this. Original issue's description: > Remove all of the CrOS Ozone configs from MB. > > Ozone is now on by default on all CrOS builds, and we don't > need to test the old x11 config any more. This CL flips > all of the CrOS builders to (implicitly) be building for Ozone, > so that we can then remove the explicit Ozone builders in a > follow-up CL. > > This builder also removes the > linux_chromium_chromeos_ozone_rel_ng builder from the CQ > since would otherwise be redundant with the > linux_chromium_chromeos_rel_ng builder. > > This CL also removes a couple of commented-out CQ entries for > builders that were removed as part of the work in bug 669297 > (linux_chromium_chromeos_compile_dbg_ng and linux_chromium_clobber_rel_ng); > at the time I had planned to re-add them once the capacity > issues were resolved, but at this point it's unclear how > important those configs are and we may want to use the > capacity for other things, and so these comments were misleading. > > R=kylechar@chromium.org, kbr@chromium.org > TBR=achuith@chromium.org, xdai@chromium.org > BUG=671355 > > Review-Url: https://codereview.chromium.org/2949093004 > Cr-Commit-Position: refs/heads/master@{#485495} > Committed: https://chromium.googlesource.com/chromium/src/+/7385c63ec2b3606a67bb192bf96311ada07aa1c6 TBR=kylechar@chromium.org,kbr@chromium.org,fjhenigman@chromium.org,dpranke@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=671355 Review-Url: https://codereview.chromium.org/2974923002 Cr-Commit-Position: refs/heads/master@{#485579} Committed: https://chromium.googlesource.com/chromium/src/+/9dfa3c95d67ac0348f208a8cb631c606b5cfa54f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -125 lines) Patch
M chrome/browser/chromeos/login/bluetooth_host_pairing_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M infra/config/cq.cfg View 1 chunk +5 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.chromiumos.json View 9 chunks +1 line, -101 lines 0 comments Download
M tools/mb/mb_config.pyl View 14 chunks +44 lines, -23 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
keishi
Created Revert of Remove all of the CrOS Ozone configs from MB.
3 years, 5 months ago (2017-07-11 10:33:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2974923002/1
3 years, 5 months ago (2017-07-11 10:34:05 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/9dfa3c95d67ac0348f208a8cb631c606b5cfa54f
3 years, 5 months ago (2017-07-11 10:34:45 UTC) #6
Dirk Pranke
3 years, 5 months ago (2017-07-11 15:41:24 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698