Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 2974853002: Assorted small animation test moves (Closed)

Created:
3 years, 5 months ago by suzyh_UTC10 (ex-contributor)
Modified:
3 years, 5 months ago
Reviewers:
meade_UTC10
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Assorted small animation test moves This patch makes a number of small rearrangements in the LayoutTests/animations directory: - Enables a disabled but passing test (font-size-using-ems) - Deletes the under-used script-tests directory (inlining the only use, animation-css-rule-types) - Moves animate-shorthand-var to the custom-properties test subdirectory - Moves four tests to a new hit-testing subdirectory - Renames a test that refers to 'players' instead of 'animations' (get-css-players -> getAnimations-css) BUG=623434 Review-Url: https://codereview.chromium.org/2974853002 Cr-Commit-Position: refs/heads/master@{#485536} Committed: https://chromium.googlesource.com/chromium/src/+/a985cd3b49007c4b1aa7b5b6b49b8af3e8bc1452

Patch Set 1 #

Patch Set 2 : Also rename test referring to 'players' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -444 lines) Patch
M third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG View 2 chunks +2 lines, -2 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/animate-shorthand-var.html View 1 chunk +0 lines, -28 lines 0 comments Download
M third_party/WebKit/LayoutTests/animations/animation-css-rule-types.html View 1 chunk +13 lines, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/animations/animation-hit-test.html View 1 chunk +0 lines, -89 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/animation-hit-test-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/animation-hit-test-transform.html View 1 chunk +0 lines, -89 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/animation-hit-test-transform-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/composited-with-hit-testing.html View 1 chunk +0 lines, -26 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/composited-with-hit-testing-expected.html View 1 chunk +0 lines, -10 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/custom-properties/animate-shorthand-var.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/font-size-using-ems.html View 0 chunks +-1 lines, --1 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/font-size-using-ems.html-disabled View 1 chunk +0 lines, -83 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/get-css-players.html View 1 1 chunk +0 lines, -39 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/getAnimations-css.html View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/hit-testing/animation-hit-test.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/hit-testing/animation-hit-test-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/hit-testing/animation-hit-test-transform.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/hit-testing/animation-hit-test-transform-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/hit-testing/composited-with-hit-testing.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/hit-testing/composited-with-hit-testing-expected.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/hit-testing/inline-element-animation-end-hit-test.html View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/animations/hit-testing/inline-element-animation-end-hit-test-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/inline-element-animation-end-hit-test.html View 1 chunk +0 lines, -41 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/inline-element-animation-end-hit-test-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/script-tests/TEMPLATE.html View 1 chunk +0 lines, -11 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/script-tests/animation-css-rule-types.js View 1 chunk +0 lines, -11 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 21 (15 generated)
suzyh_UTC10 (ex-contributor)
3 years, 5 months ago (2017-07-11 00:33:06 UTC) #3
meade_UTC10
lgtm
3 years, 5 months ago (2017-07-11 02:54:51 UTC) #8
suzyh_UTC10 (ex-contributor)
I've added one more rename to this patch (instead of spinning up another small patch), ...
3 years, 5 months ago (2017-07-11 04:37:48 UTC) #10
meade_UTC10
On 2017/07/11 04:37:48, suzyh_UTC10 wrote: > I've added one more rename to this patch (instead ...
3 years, 5 months ago (2017-07-11 04:46:43 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2974853002/20001
3 years, 5 months ago (2017-07-11 06:32:24 UTC) #18
commit-bot: I haz the power
3 years, 5 months ago (2017-07-11 06:37:11 UTC) #21
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/a985cd3b49007c4b1aa7b5b6b49b...

Powered by Google App Engine
This is Rietveld 408576698