Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 2974823004: [LayoutNG] Fix inline ComputeMinMaxContentSize() (Closed)

Created:
3 years, 5 months ago by kojii
Modified:
3 years, 5 months ago
Reviewers:
cbiesinger, ikilpatrick, eae
CC:
atotic+reviews_chromium.org, blink-reviews, blink-reviews-layout_chromium.org, cbiesinger, chromium-reviews, dgrogan+ng_chromium.org, eae+blinkwatch, glebl+reviews_chromium.org, jchaffraix+rendering, lchoi+reviews_chromium.org, leviw+renderwatch, ojan+watch_chromium.org, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[LayoutNG] Fix inline ComputeMinMaxContentSize() This patch fixes two issues in NGInlineNode::ComputeMinMaxContentSize() 1. The max-content algorithm was incorrect. Fixed to compute the max of line widths when available width is infinite. 2. Negative text-indent can make min > max. CSSWG test indicates we should take min of the two values in the case. BUG=636993 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng Review-Url: https://codereview.chromium.org/2974823004 Cr-Commit-Position: refs/heads/master@{#485890} Committed: https://chromium.googlesource.com/chromium/src/+/c8532b25d4af1355089002e5a7ba913409194d83

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -15 lines) Patch
M third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/inline/ng_inline_node.cc View 3 chunks +6 lines, -12 lines 0 comments Download

Messages

Total messages: 20 (13 generated)
kojii
PTAL.
3 years, 5 months ago (2017-07-11 08:02:16 UTC) #6
ikilpatrick
lgtm
3 years, 5 months ago (2017-07-11 16:55:01 UTC) #10
eae
LGTM
3 years, 5 months ago (2017-07-11 22:21:04 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2974823004/1
3 years, 5 months ago (2017-07-12 04:18:01 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/426095)
3 years, 5 months ago (2017-07-12 05:28:56 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2974823004/1
3 years, 5 months ago (2017-07-12 07:29:29 UTC) #17
commit-bot: I haz the power
3 years, 5 months ago (2017-07-12 07:43:57 UTC) #20
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c8532b25d4af1355089002e5a7ba...

Powered by Google App Engine
This is Rietveld 408576698