Store FunctionType(s) of local functions by value.

Store FunctionType(s) of local functions by value.

R=paulberry@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/c393e9bbbd1be887f48a8753b4ddbc65820c4548

[Paul Berry, 2017-07-10 18:32:46]

I don't think this is going to work.  See comment below.

https://codereview.chromium.org/2974803002/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/idl.dart (right):

https://codereview.chromium.org/2974803002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/idl.dart:837: @deprecated
I'm worried that this will cause compatibility issues when rolled into the
Google internal codebase, because code that consumes summaries will get updated
before code that generates summaries.  So there will be a period of time where
some summaries exist that were generated by the old analyzer but need to be
consumed by the new analyzer.  Can we modify this CL to just change how
summaries are generated, and postpone the changes to how summaries are consumed
until later?

[scheglov, 2017-07-10 19:41:10]

PTAL

I updated the CL to store additional information (FunctionElement by value), but
keep the old information and the same implementation for reading summaries.

[Paul Berry, 2017-07-11 16:41:51]

lgtm

[scheglov, 2017-07-11 18:36:25]

Description was changed from

==========
Store FunctionType(s) of local functions by value.

R=paulberry@google.com
BUG=
==========

to

==========
Store FunctionType(s) of local functions by value.

R=paulberry@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/c393e9bbbd1be887f48a8753b4ddbc65820c4548
==========

[scheglov, 2017-07-11 18:36:27]

Committed patchset #2 (id:20001) manually as
c393e9bbbd1be887f48a8753b4ddbc65820c4548 (presubmit successful).