Store FunctionType(s) of local functions by value.

pkg/analyzer/lib/src/summary/idl.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * This file is an "idl" style description of the summary format.  It
  * contains abstract classes which declare the interface for reading data from
  * summaries.  It is parsed and transformed into code that implements the
  * summary format.
  *
@@ skipping 816 matching lines @@
    */
   @Id(2)
   ReferenceKind get kind;
 
   /**
    * If [kind] is [ReferenceKind.function] (that is, the entity being referred
    * to is a local function), the index of the function within
    * [UnlinkedExecutable.localFunctions].  Otherwise zero.
    */
   @Id(6)
+  @deprecated

[Paul Berry, 2017/07/10 18:32:46]

I'm worried that this will cause compatibility issues when rolled into the
Google internal codebase, because code that consumes summaries will get updated
before code that generates summaries.  So there will be a period of time where
some summaries exist that were generated by the old analyzer but need to be
consumed by the new analyzer.  Can we modify this CL to just change how
summaries are generated, and postpone the changes to how summaries are consumed
until later?

   int get localIndex;
 
   /**
    * If this [LinkedReference] doesn't have an associated [UnlinkedReference],
    * name of the entity being referred to.  For the pseudo-type `dynamic`, the
    * string is "dynamic".  For the pseudo-type `void`, the string is "void".
    */
   @Id(3)
   String get name;
 
@@ skipping 2505 matching lines @@
   @Id(11)
   int get visibleLength;
 
   /**
    * If a local variable, the beginning of the visible range; zero otherwise.
    */
   @informative
   @Id(12)
   int get visibleOffset;
 }