Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 2974793002: [milo] build_source -> buildSource. (Closed)

Created:
3 years, 5 months ago by iannucci
Modified:
3 years, 5 months ago
Reviewers:
Ryan Tseng, hinoka
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

[milo] build_source -> buildsource. Because apparently go tooling gets constantly annoyed by underscores. R=hinoka@chromium.org BUG= Review-Url: https://codereview.chromium.org/2974793002 Committed: https://github.com/luci/luci-go/commit/48dd1818b5e5ea8debff6ef2fb5fbb86291be985

Patch Set 1 #

Total comments: 1

Patch Set 2 : move raw_presentation too #

Patch Set 3 : buildsource #

Patch Set 4 : rawpresentation too #

Patch Set 5 : reupload #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-37 lines, -23071 lines) Patch
D milo/build_source/buildbot/build.go View 1 2 3 4 1 chunk +0 lines, -661 lines 0 comments Download
D milo/build_source/buildbot/build_test.go View 1 2 3 4 1 chunk +0 lines, -113 lines 0 comments Download
D milo/build_source/buildbot/builder.go View 1 2 3 4 1 chunk +0 lines, -298 lines 0 comments Download
D milo/build_source/buildbot/builder_test.go View 1 2 3 4 1 chunk +0 lines, -93 lines 0 comments Download
D milo/build_source/buildbot/buildinfo.go View 1 2 3 4 1 chunk +0 lines, -273 lines 0 comments Download
D milo/build_source/buildbot/buildinfo_test.go View 1 2 3 4 1 chunk +0 lines, -376 lines 0 comments Download
D milo/build_source/buildbot/console.go View 1 2 3 4 1 chunk +0 lines, -96 lines 0 comments Download
D milo/build_source/buildbot/console_test.go View 1 2 3 4 1 chunk +0 lines, -70 lines 0 comments Download
D milo/build_source/buildbot/datastore.go View 1 2 3 4 1 chunk +0 lines, -55 lines 0 comments Download
D milo/build_source/buildbot/expectations/CrWinGoma.30608.build.json View 1 2 3 4 1 chunk +0 lines, -901 lines 0 comments Download
D milo/build_source/buildbot/expectations/chromium_presubmit.426944.build.json View 1 2 3 4 1 chunk +0 lines, -553 lines 0 comments Download
D milo/build_source/buildbot/expectations/gerritCL.1234.build.json View 1 2 3 4 1 chunk +0 lines, -84 lines 0 comments Download
D milo/build_source/buildbot/expectations/newline.1234.build.json View 1 2 3 4 1 chunk +0 lines, -67 lines 0 comments Download
D milo/build_source/buildbot/expectations/win_chromium_rel_ng.246309.build.json View 1 2 3 4 1 chunk +0 lines, -1005 lines 0 comments Download
D milo/build_source/buildbot/grpc.go View 1 2 3 4 1 chunk +0 lines, -233 lines 0 comments Download
D milo/build_source/buildbot/grpc_test.go View 1 2 3 4 1 chunk +0 lines, -143 lines 0 comments Download
D milo/build_source/buildbot/html.go View 1 2 3 4 1 chunk +0 lines, -100 lines 0 comments Download
D milo/build_source/buildbot/html_data.go View 1 2 3 4 1 chunk +0 lines, -13 lines 0 comments Download
D milo/build_source/buildbot/html_test.go View 1 2 3 4 1 chunk +0 lines, -103 lines 0 comments Download
D milo/build_source/buildbot/master.go View 1 2 3 4 1 chunk +0 lines, -151 lines 0 comments Download
D milo/build_source/buildbot/master_test.go View 1 2 3 4 1 chunk +0 lines, -41 lines 0 comments Download
D milo/build_source/buildbot/pubsub.go View 1 2 3 4 1 chunk +0 lines, -407 lines 0 comments Download
D milo/build_source/buildbot/pubsub_test.go View 1 2 3 4 1 chunk +0 lines, -494 lines 0 comments Download
D milo/build_source/buildbot/structs.go View 1 2 3 4 1 chunk +0 lines, -439 lines 0 comments Download
D milo/build_source/buildbot/testdata/CrWinGoma.30608.json View 1 2 3 4 1 chunk +0 lines, -1425 lines 0 comments Download
D milo/build_source/buildbot/testdata/chromium_presubmit.426944.json View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
D milo/build_source/buildbot/testdata/gerritCL.1234.json View 1 2 3 4 1 chunk +0 lines, -58 lines 0 comments Download
D milo/build_source/buildbot/testdata/newline.1234.json View 1 2 3 4 1 chunk +0 lines, -46 lines 0 comments Download
D milo/build_source/buildbot/testdata/win_chromium_rel_ng.246309.json View 1 2 3 4 1 chunk +0 lines, -1362 lines 0 comments Download
D milo/build_source/buildbucket/buckets.go View 1 2 3 4 1 chunk +0 lines, -49 lines 0 comments Download
D milo/build_source/buildbucket/builder.go View 1 2 3 4 1 chunk +0 lines, -297 lines 0 comments Download
D milo/build_source/buildbucket/builder_test.go View 1 2 3 4 1 chunk +0 lines, -84 lines 0 comments Download
D milo/build_source/buildbucket/common.go View 1 2 3 4 1 chunk +0 lines, -151 lines 0 comments Download
D milo/build_source/buildbucket/expectations/master.tryserver.infra/InfraPresubmit.json View 1 2 3 4 1 chunk +0 lines, -98 lines 0 comments Download
D milo/build_source/buildbucket/expectations/master.tryserver.infra/InfraPresubmit.Swarming.json View 1 2 3 4 1 chunk +0 lines, -53 lines 0 comments Download
D milo/build_source/buildbucket/html.go View 1 2 3 4 1 chunk +0 lines, -59 lines 0 comments Download
D milo/build_source/buildbucket/properties.go View 1 2 3 4 1 chunk +0 lines, -72 lines 0 comments Download
D milo/build_source/buildbucket/testdata/master.tryserver.infra/InfraPresubmit.json View 1 2 3 4 1 chunk +0 lines, -210 lines 0 comments Download
D milo/build_source/buildbucket/testdata/master.tryserver.infra/InfraPresubmit.Swarming.json View 1 2 3 4 1 chunk +0 lines, -415 lines 0 comments Download
D milo/build_source/raw_presentation/build.go View 1 2 3 4 1 chunk +0 lines, -223 lines 0 comments Download
D milo/build_source/raw_presentation/html.go View 1 2 3 4 1 chunk +0 lines, -115 lines 0 comments Download
D milo/build_source/raw_presentation/internal/gen.go View 1 2 3 4 1 chunk +0 lines, -7 lines 0 comments Download
D milo/build_source/raw_presentation/internal/stream.proto View 1 2 3 4 1 chunk +0 lines, -19 lines 0 comments Download
D milo/build_source/raw_presentation/internal/stream.pb.go View 1 2 3 4 1 chunk +0 lines, -81 lines 0 comments Download
D milo/build_source/raw_presentation/logDogBuild.go View 1 2 3 4 1 chunk +0 lines, -234 lines 0 comments Download
D milo/build_source/raw_presentation/logDogStream.go View 1 2 3 4 1 chunk +0 lines, -43 lines 0 comments Download
D milo/build_source/swarming/README.md View 1 2 3 4 1 chunk +0 lines, -9 lines 0 comments Download
D milo/build_source/swarming/build.go View 1 2 3 4 1 chunk +0 lines, -777 lines 0 comments Download
D milo/build_source/swarming/buildLog.go View 1 2 3 4 1 chunk +0 lines, -69 lines 0 comments Download
D milo/build_source/swarming/buildLog_test.go View 1 2 3 4 1 chunk +0 lines, -34 lines 0 comments Download
D milo/build_source/swarming/build_test.go View 1 2 3 4 1 chunk +0 lines, -122 lines 0 comments Download
D milo/build_source/swarming/buildinfo.go View 1 2 3 4 1 chunk +0 lines, -269 lines 0 comments Download
D milo/build_source/swarming/buildinfo_test.go View 1 2 3 4 1 chunk +0 lines, -249 lines 0 comments Download
D milo/build_source/swarming/expectations/build-canceled.json View 1 2 3 4 1 chunk +0 lines, -144 lines 0 comments Download
D milo/build_source/swarming/expectations/build-exception.json View 1 2 3 4 1 chunk +0 lines, -180 lines 0 comments Download
D milo/build_source/swarming/expectations/build-expired.json View 1 2 3 4 1 chunk +0 lines, -53 lines 0 comments Download
D milo/build_source/swarming/expectations/build-finished-logdog-expired-stream.json View 1 2 3 4 1 chunk +0 lines, -45 lines 0 comments Download
D milo/build_source/swarming/expectations/build-gerrit.json View 1 2 3 4 1 chunk +0 lines, -89 lines 0 comments Download
D milo/build_source/swarming/expectations/build-internal.json View 1 2 3 4 1 chunk +0 lines, -72 lines 0 comments Download
D milo/build_source/swarming/expectations/build-link.json View 1 2 3 4 1 chunk +0 lines, -72 lines 0 comments Download
D milo/build_source/swarming/expectations/build-nested.json View 1 2 3 4 1 chunk +0 lines, -290 lines 0 comments Download
D milo/build_source/swarming/expectations/build-patch-failure.json View 1 2 3 4 1 chunk +0 lines, -249 lines 0 comments Download
D milo/build_source/swarming/expectations/build-pending.json View 1 2 3 4 1 chunk +0 lines, -32 lines 0 comments Download
D milo/build_source/swarming/expectations/build-pending-logdog.json View 1 2 3 4 1 chunk +0 lines, -32 lines 0 comments Download
D milo/build_source/swarming/expectations/build-running.json View 1 2 3 4 1 chunk +0 lines, -133 lines 0 comments Download
D milo/build_source/swarming/expectations/build-running-logdog.json View 1 2 3 4 1 chunk +0 lines, -139 lines 0 comments Download
D milo/build_source/swarming/expectations/build-running-logdog-no-annotation-stream.json View 1 2 3 4 1 chunk +0 lines, -35 lines 0 comments Download
D milo/build_source/swarming/expectations/build-timeout.json View 1 2 3 4 1 chunk +0 lines, -148 lines 0 comments Download
D milo/build_source/swarming/expectations/build-unicode.json View 1 2 3 4 1 chunk +0 lines, -133 lines 0 comments Download
D milo/build_source/swarming/html.go View 1 2 3 4 1 chunk +0 lines, -145 lines 0 comments Download
D milo/build_source/swarming/html_data.go View 1 2 3 4 1 chunk +0 lines, -299 lines 0 comments Download
D milo/build_source/swarming/html_test.go View 1 2 3 4 1 chunk +0 lines, -72 lines 0 comments Download
D milo/build_source/swarming/memoryClient.go View 1 2 3 4 1 chunk +0 lines, -192 lines 0 comments Download
D milo/build_source/swarming/testdata/build-canceled View 1 2 3 4 1 chunk +0 lines, -74 lines 0 comments Download
D milo/build_source/swarming/testdata/build-canceled.swarm View 1 2 3 4 1 chunk +0 lines, -99 lines 0 comments Download
D milo/build_source/swarming/testdata/build-exception View 1 2 3 4 1 chunk +0 lines, -191 lines 0 comments Download
D milo/build_source/swarming/testdata/build-exception.swarm View 1 2 3 4 1 chunk +0 lines, -10 lines 0 comments Download
D milo/build_source/swarming/testdata/build-expired.swarm View 1 2 3 4 1 chunk +0 lines, -32 lines 0 comments Download
D milo/build_source/swarming/testdata/build-finished-logdog-expired-stream View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
D milo/build_source/swarming/testdata/build-finished-logdog-expired-stream.swarm View 1 2 3 4 1 chunk +0 lines, -12 lines 0 comments Download
D milo/build_source/swarming/testdata/build-gerrit View 1 2 3 4 1 chunk +0 lines, -11 lines 0 comments Download
D milo/build_source/swarming/testdata/build-gerrit.swarm View 1 2 3 4 1 chunk +0 lines, -9 lines 0 comments Download
D milo/build_source/swarming/testdata/build-internal View 1 2 3 4 1 chunk +0 lines, -11 lines 0 comments Download
D milo/build_source/swarming/testdata/build-internal.swarm View 1 2 3 4 1 chunk +0 lines, -8 lines 0 comments Download
D milo/build_source/swarming/testdata/build-link View 1 2 3 4 1 chunk +0 lines, -11 lines 0 comments Download
D milo/build_source/swarming/testdata/build-link.swarm View 1 2 3 4 1 chunk +0 lines, -8 lines 0 comments Download
D milo/build_source/swarming/testdata/build-nested View 1 2 3 4 1 chunk +0 lines, -256 lines 0 comments Download
D milo/build_source/swarming/testdata/build-nested.swarm View 1 2 3 4 1 chunk +0 lines, -8 lines 0 comments Download
D milo/build_source/swarming/testdata/build-patch-failure View 1 2 3 4 1 chunk +0 lines, -5888 lines 0 comments Download
D milo/build_source/swarming/testdata/build-patch-failure.swarm View 1 2 3 4 1 chunk +0 lines, -8 lines 0 comments Download
D milo/build_source/swarming/testdata/build-pending.swarm View 1 2 3 4 1 chunk +0 lines, -19 lines 0 comments Download
D milo/build_source/swarming/testdata/build-pending-logdog.swarm View 1 2 3 4 1 chunk +0 lines, -21 lines 0 comments Download
D milo/build_source/swarming/testdata/build-running View 1 2 3 4 1 chunk +0 lines, -92 lines 0 comments Download
D milo/build_source/swarming/testdata/build-running.swarm View 1 2 3 4 1 chunk +0 lines, -8 lines 0 comments Download
D milo/build_source/swarming/testdata/build-running-logdog View 1 2 3 4 1 chunk +0 lines, -8 lines 0 comments Download
D milo/build_source/swarming/testdata/build-running-logdog.swarm View 1 2 3 4 1 chunk +0 lines, -10 lines 0 comments Download
D milo/build_source/swarming/testdata/build-running-logdog-no-annotation-stream.swarm View 1 2 3 4 1 chunk +0 lines, -10 lines 0 comments Download
D milo/build_source/swarming/testdata/build-running-logdog.pb.txt View 1 2 3 4 1 chunk +0 lines, -74 lines 0 comments Download
D milo/build_source/swarming/testdata/build-timeout View 1 2 3 4 1 chunk +0 lines, -74 lines 0 comments Download
D milo/build_source/swarming/testdata/build-timeout.swarm View 1 2 3 4 1 chunk +0 lines, -99 lines 0 comments Download
D milo/build_source/swarming/testdata/build-unicode View 1 2 3 4 1 chunk +0 lines, -94 lines 0 comments Download
D milo/build_source/swarming/testdata/build-unicode.swarm View 1 2 3 4 1 chunk +0 lines, -8 lines 0 comments Download
A + milo/buildsource/buildbot/build.go View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + milo/buildsource/buildbot/build_test.go View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + milo/buildsource/buildbot/builder.go View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + milo/buildsource/buildbot/builder_test.go View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + milo/buildsource/buildbot/buildinfo.go View 1 2 3 4 3 chunks +3 lines, -3 lines 0 comments Download
A + milo/buildsource/buildbot/buildinfo_test.go View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + milo/buildsource/buildbot/console.go View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + milo/buildsource/buildbot/console_test.go View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + milo/buildsource/buildbot/datastore.go View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + milo/buildsource/buildbot/expectations/CrWinGoma.30608.build.json View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + milo/buildsource/buildbot/expectations/chromium_presubmit.426944.build.json View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + milo/buildsource/buildbot/expectations/gerritCL.1234.build.json View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + milo/buildsource/buildbot/expectations/newline.1234.build.json View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + milo/buildsource/buildbot/expectations/win_chromium_rel_ng.246309.build.json View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + milo/buildsource/buildbot/grpc.go View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + milo/buildsource/buildbot/grpc_test.go View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + milo/buildsource/buildbot/html.go View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + milo/buildsource/buildbot/html_data.go View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + milo/buildsource/buildbot/html_test.go View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + milo/buildsource/buildbot/master.go View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + milo/buildsource/buildbot/master_test.go View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + milo/buildsource/buildbot/pubsub.go View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + milo/buildsource/buildbot/pubsub_test.go View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + milo/buildsource/buildbot/structs.go View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + milo/buildsource/buildbot/testdata/CrWinGoma.30608.json View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + milo/buildsource/buildbot/testdata/chromium_presubmit.426944.json View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + milo/buildsource/buildbot/testdata/gerritCL.1234.json View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + milo/buildsource/buildbot/testdata/newline.1234.json View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + milo/buildsource/buildbot/testdata/win_chromium_rel_ng.246309.json View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + milo/buildsource/buildbucket/buckets.go View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + milo/buildsource/buildbucket/builder.go View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + milo/buildsource/buildbucket/builder_test.go View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + milo/buildsource/buildbucket/common.go View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + milo/buildsource/buildbucket/expectations/master.tryserver.infra/InfraPresubmit.json View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + milo/buildsource/buildbucket/expectations/master.tryserver.infra/InfraPresubmit.Swarming.json View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + milo/buildsource/buildbucket/html.go View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + milo/buildsource/buildbucket/properties.go View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + milo/buildsource/buildbucket/testdata/master.tryserver.infra/InfraPresubmit.json View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + milo/buildsource/buildbucket/testdata/master.tryserver.infra/InfraPresubmit.Swarming.json View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + milo/buildsource/rawpresentation/build.go View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
A + milo/buildsource/rawpresentation/html.go View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
A + milo/buildsource/rawpresentation/internal/gen.go View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + milo/buildsource/rawpresentation/internal/stream.proto View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + milo/buildsource/rawpresentation/internal/stream.pb.go View 1 2 3 4 2 chunks +16 lines, -16 lines 0 comments Download
A + milo/buildsource/rawpresentation/logDogBuild.go View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
A + milo/buildsource/rawpresentation/logDogStream.go View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
A + milo/buildsource/swarming/README.md View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + milo/buildsource/swarming/build.go View 1 2 3 4 6 chunks +9 lines, -9 lines 0 comments Download
A + milo/buildsource/swarming/buildLog.go View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + milo/buildsource/swarming/buildLog_test.go View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + milo/buildsource/swarming/build_test.go View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + milo/buildsource/swarming/buildinfo.go View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + milo/buildsource/swarming/buildinfo_test.go View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + milo/buildsource/swarming/expectations/build-canceled.json View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + milo/buildsource/swarming/expectations/build-exception.json View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + milo/buildsource/swarming/expectations/build-expired.json View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + milo/buildsource/swarming/expectations/build-finished-logdog-expired-stream.json View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + milo/buildsource/swarming/expectations/build-gerrit.json View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + milo/buildsource/swarming/expectations/build-internal.json View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + milo/buildsource/swarming/expectations/build-link.json View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + milo/buildsource/swarming/expectations/build-nested.json View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + milo/buildsource/swarming/expectations/build-patch-failure.json View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + milo/buildsource/swarming/expectations/build-pending.json View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + milo/buildsource/swarming/expectations/build-pending-logdog.json View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + milo/buildsource/swarming/expectations/build-running.json View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + milo/buildsource/swarming/expectations/build-running-logdog.json View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + milo/buildsource/swarming/expectations/build-running-logdog-no-annotation-stream.json View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + milo/buildsource/swarming/expectations/build-timeout.json View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + milo/buildsource/swarming/expectations/build-unicode.json View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + milo/buildsource/swarming/html.go View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + milo/buildsource/swarming/html_data.go View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
A + milo/buildsource/swarming/html_test.go View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + milo/buildsource/swarming/memoryClient.go View 1 2 3 4 5 chunks +8 lines, -8 lines 0 comments Download
A + milo/buildsource/swarming/testdata/build-canceled View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + milo/buildsource/swarming/testdata/build-canceled.swarm View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + milo/buildsource/swarming/testdata/build-exception View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + milo/buildsource/swarming/testdata/build-exception.swarm View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + milo/buildsource/swarming/testdata/build-expired.swarm View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + milo/buildsource/swarming/testdata/build-finished-logdog-expired-stream View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + milo/buildsource/swarming/testdata/build-finished-logdog-expired-stream.swarm View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + milo/buildsource/swarming/testdata/build-gerrit View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + milo/buildsource/swarming/testdata/build-gerrit.swarm View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + milo/buildsource/swarming/testdata/build-internal View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + milo/buildsource/swarming/testdata/build-internal.swarm View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + milo/buildsource/swarming/testdata/build-link View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + milo/buildsource/swarming/testdata/build-link.swarm View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + milo/buildsource/swarming/testdata/build-nested View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + milo/buildsource/swarming/testdata/build-nested.swarm View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + milo/buildsource/swarming/testdata/build-patch-failure View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + milo/buildsource/swarming/testdata/build-patch-failure.swarm View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + milo/buildsource/swarming/testdata/build-pending.swarm View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + milo/buildsource/swarming/testdata/build-pending-logdog.swarm View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + milo/buildsource/swarming/testdata/build-running View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + milo/buildsource/swarming/testdata/build-running.swarm View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + milo/buildsource/swarming/testdata/build-running-logdog View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + milo/buildsource/swarming/testdata/build-running-logdog.swarm View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + milo/buildsource/swarming/testdata/build-running-logdog-no-annotation-stream.swarm View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + milo/buildsource/swarming/testdata/build-running-logdog.pb.txt View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + milo/buildsource/swarming/testdata/build-timeout View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + milo/buildsource/swarming/testdata/build-timeout.swarm View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + milo/buildsource/swarming/testdata/build-unicode View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + milo/buildsource/swarming/testdata/build-unicode.swarm View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
M milo/frontend/buildbot_data.go View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M milo/frontend/console/console.go View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M milo/frontend/frontpage.go View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M milo/frontend/main.go View 1 2 3 4 2 chunks +5 lines, -5 lines 0 comments Download
M milo/frontend/main_test.go View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M milo/rpc/buildinfo.go View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 26 (20 generated)
iannucci
3 years, 5 months ago (2017-07-10 16:54:21 UTC) #1
Ryan Tseng
lgtm Strange :/ https://codereview.chromium.org/2974793002/diff/1/milo/buildSource/raw_presentation/build.go File milo/buildSource/raw_presentation/build.go (right): https://codereview.chromium.org/2974793002/diff/1/milo/buildSource/raw_presentation/build.go#newcode5 milo/buildSource/raw_presentation/build.go:5: package raw_presentation This too?
3 years, 5 months ago (2017-07-10 17:03:42 UTC) #7
iannucci
On 2017/07/10 17:03:42, Ryan Tseng wrote: > lgtm > > Strange :/ > > https://codereview.chromium.org/2974793002/diff/1/milo/buildSource/raw_presentation/build.go ...
3 years, 5 months ago (2017-07-10 18:29:06 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2974793002/20001
3 years, 5 months ago (2017-07-10 18:31:32 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2974793002/40001
3 years, 5 months ago (2017-07-10 18:39:24 UTC) #23
commit-bot: I haz the power
3 years, 5 months ago (2017-07-10 18:47:07 UTC) #26
Message was sent while issue was closed.
Committed patchset #5 (id:40001) as
https://github.com/luci/luci-go/commit/48dd1818b5e5ea8debff6ef2fb5fbb86291be985

Powered by Google App Engine
This is Rietveld 408576698