Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2974653002: Changing XPathGrammer.y to not use global using blink (Closed)

Created:
3 years, 5 months ago by Daniel Bratell
Modified:
3 years, 5 months ago
Reviewers:
fs
CC:
blink-reviews, chromium-reviews, dominicc+watchlist_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Changing XPathGrammer.y to not use global using blink When using "using namespace Foo" at global level you will introduce a lot of symbols into the global scope which will make it harder for jumbo (unity builds/merged files) to compile without symbol collisions. Also, global using namespace statements will, with the current implementation of jumbo not compile because of a compiler warning. This patch changes to more explicit namespaces. BUG= Review-Url: https://codereview.chromium.org/2974653002 Cr-Commit-Position: refs/heads/master@{#484928} Committed: https://chromium.googlesource.com/chromium/src/+/520115400d66bb2988b0ba8dcfa12397b9f1af2a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -24 lines) Patch
M third_party/WebKit/Source/core/xml/XPathGrammar.y View 18 chunks +22 lines, -24 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Daniel Bratell
fs, can you please take a look, or suggest a suitable reviewer? This file isn't ...
3 years, 5 months ago (2017-07-07 13:34:36 UTC) #4
fs
lgtm
3 years, 5 months ago (2017-07-07 13:37:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2974653002/1
3 years, 5 months ago (2017-07-07 13:40:24 UTC) #8
commit-bot: I haz the power
3 years, 5 months ago (2017-07-07 15:14:17 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/520115400d66bb2988b0ba8dcfa1...

Powered by Google App Engine
This is Rietveld 408576698