Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Issue 2974643002: Revert of Disable flaky WebRtcMediaRecorderTest tests on TSAN (Closed)

Created:
3 years, 5 months ago by ossu-chromium
Modified:
3 years, 5 months ago
CC:
chromium-reviews, jam, darin-cc_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Disable flaky WebRtcMediaRecorderTest tests on TSAN (patchset #1 id:1 of https://codereview.chromium.org/2969613002/ ) Reason for revert: The underlying problem should now be solved. Original issue's description: > Disable flaky WebRtcMediaRecorderTest tests on TSAN > > Disable the following flaky WebRtcMediaRecorderTest tests on TSAN: > StartAndDataAvailable > IllegalStopThrowsDOMError > IllegalStartWhileRecordingThrowsDOMError > > TBR=ossu > BUG=736268 > > Review-Url: https://codereview.chromium.org/2969613002 > Cr-Commit-Position: refs/heads/master@{#483633} > Committed: https://chromium.googlesource.com/chromium/src/+/8e7f9967cab8bb7eba9af7f29d63c69dff2c72b5 TBR=timloh@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=736268 Review-Url: https://codereview.chromium.org/2974643002 Cr-Commit-Position: refs/heads/master@{#484936} Committed: https://chromium.googlesource.com/chromium/src/+/9d93c4adcaf03b9dadc1ac11ed9d29332efebf8a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -25 lines) Patch
M content/browser/webrtc/webrtc_media_recorder_browsertest.cc View 2 chunks +4 lines, -25 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
ossu-chromium
Created Revert of Disable flaky WebRtcMediaRecorderTest tests on TSAN
3 years, 5 months ago (2017-07-07 12:00:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2974643002/1
3 years, 5 months ago (2017-07-07 12:00:44 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 5 months ago (2017-07-07 12:00:45 UTC) #5
Guido Urdaneta
lgtm
3 years, 5 months ago (2017-07-07 14:40:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2974643002/1
3 years, 5 months ago (2017-07-07 14:44:00 UTC) #9
commit-bot: I haz the power
3 years, 5 months ago (2017-07-07 15:33:54 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9d93c4adcaf03b9dadc1ac11ed9d...

Powered by Google App Engine
This is Rietveld 408576698