chrome/android/webapk/libs/common/src/org/chromium/webapk/lib/common/IdentityService/IIdentityService.aidl - Issue 2974573002: Refactor WebApkServiceConnectionManager.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/webapk/libs/common/src/org/chromium/webapk/lib/common/IdentityService/IIdentityService.aidl

Issue 2974573002: Refactor WebApkServiceConnectionManager. (Closed)

Patch Set: Call the callback on UI thread if bindService() fails. Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/webapk/libs/client/src/org/chromium/webapk/lib/client/WebApkValidator.java ('K') | « chrome/android/webapk/libs/common/BUILD.gn ('k') | chrome/android/webapk/libs/common/src/org/chromium/webapk/lib/common/IdentityService/common.aidl » ('j') | chrome/android/webapk/shell_apk/AndroidManifest.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/webapk/libs/common/src/org/chromium/webapk/lib/common/IdentityService/IIdentityService.aidl

diff --git a/chrome/android/webapk/libs/common/src/org/chromium/webapk/lib/common/IdentityService/IIdentityService.aidl b/chrome/android/webapk/libs/common/src/org/chromium/webapk/lib/common/IdentityService/IIdentityService.aidl

new file mode 100644

index 0000000000000000000000000000000000000000..973dece82ab16d542cfc725da1f8fc9e8e03687e

--- /dev/null

+++ b/chrome/android/webapk/libs/common/src/org/chromium/webapk/lib/common/IdentityService/IIdentityService.aidl

@@ -0,0 +1,11 @@

+// Use of this source code is governed by a BSD-style license that can be

+// found in the LICENSE file.

+package org.chromium.webapk.lib.common.IdentityService;

pkotwicz 2017/07/14 23:20:05 Based on a code search, package names with upper c

Xi Han 2017/07/17 20:45:32 Thanks for catching it, renamed.

+/** Interface for communicating between WebAPK Identity Service and Chrome. */

pkotwicz 2017/07/14 23:20:05 If you change the comment in IdentityService.java

Xi Han 2017/07/17 20:45:32 Done.

+interface IIdentityService {

+ // Gets the package name of its runtime host browser.

+ String getRuntimeHostBrowserPackageName();