Refactor WebApkServiceConnectionManager.

chrome/android/webapk/libs/client/src/org/chromium/webapk/lib/client/WebApkValidator.java

Index: chrome/android/webapk/libs/client/src/org/chromium/webapk/lib/client/WebApkValidator.java
diff --git a/chrome/android/webapk/libs/client/src/org/chromium/webapk/lib/client/WebApkValidator.java b/chrome/android/webapk/libs/client/src/org/chromium/webapk/lib/client/WebApkValidator.java
index 2fc1e46694f8cdc92fbab00bdff47e7cd9de9809..81158f91a9941f1c0104a6fab4081224a0d03678 100644
--- a/chrome/android/webapk/libs/client/src/org/chromium/webapk/lib/client/WebApkValidator.java
+++ b/chrome/android/webapk/libs/client/src/org/chromium/webapk/lib/client/WebApkValidator.java
@@ -44,6 +44,17 @@ public class WebApkValidator {
     private static byte[] sCommentSignedPublicKeyBytes;
     private static PublicKey sCommentSignedPublicKey;
 
+    /** Used to notified the consumer after checking whether the current app owns the WebAPK. */
+    public abstract static class IsOwnedCheckCallback
+            implements WebApkIdentityServiceClient.CheckRuntimeHostCallback {
+        public abstract void onIsOwnedChecked(boolean isOwned);
+
+        @Override
+        public void onCheckedRuntimeHost(boolean isValid) {
+            onIsOwnedChecked(isValid);
+        }
+    }
+
     /**
      * Queries the PackageManager to determine whether a WebAPK can handle the URL. Ignores whether
      * the user has selected a default handler for the URL and whether the default handler is the
@@ -103,6 +114,13 @@ public class WebApkValidator {
         return false;
     }
 
+    /** Checks whether the current app is the runtime host of the WebAPK asynchronously. */

[pkotwicz, 2017/07/14 23:20:05]

Nit: "current app" -> "Chrome"

[Xi Han, 2017/07/17 20:45:32]

Done.

+    public static void isOwnedWebApkAsync(

[pkotwicz, 2017/07/14 23:20:05]

1) Can you please rename this method to checkChromeBacksWebApkAsync()
2) You can rename IsOwnedCheckCallback to CheckChromeBacksWebApkCallback
I suggest that CheckChromeBacksWebApkCallback has a method called
onChecked(boolean doesChromeBackWebApk) {}
3) I talked to Yaron, and I argued that we can have
WebApkValidator#checkChromeBacksWebApkAsync() but that
WebApkValidator#checkChromeBacksWebApkAsync() and
WebApkIdentifyServiceClient#checkChromeBacksWebApkAsync() should use the same
callback class. Yaron agreed with me. 🙌!

[Xi Han, 2017/07/17 20:45:32]

Done.
Done.
We should avoid browser-specific naming in the WebApkIdentityserviceClient.
I just thought it would like wired when you call ChromeWebApkHost.check...() and
pass in a WebApkIdentifyServiceClient callback. Anyway, remove the callback
defined in the ChromeWebApkHost.

+            Context appContext, String webApkPackageName, IsOwnedCheckCallback callback) {
+        WebApkIdentityServiceClient.checkWebApkRuntimeHostAsync(
+                appContext, webApkPackageName, callback);

[pkotwicz, 2017/07/14 23:20:05]

1) WebApkIdentityServiceClient#checkWebApkRuntimeHostAsync() should be renamed
to WebApkIdentityServiceClient#checkChromeBacksWebApkAsync() (Both functions
should have the same name to avoid confusion)
2) You can make WebApkIdentityServiceClient#checkChromeBacksWebApkAsync()
non-static so that this method "does something"

[Xi Han, 2017/07/17 20:45:32]

WebApkIdentityServiceClient shouldn't have browser-specific naming.

[pkotwicz, 2017/07/18 17:30:47]

Fair point. In this case you can can rename the function to
WebApkIdentityServiceClient#checkBrowserBacksWebApkAsync()

+    }
+
     /**
      * Fetches the list of resolve infos from the PackageManager that can handle the URL.
      *