Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 2974323003: Remove all calls to domAutomationController.setAutomationId. (Closed)

Created:
3 years, 5 months ago by Łukasz Anforowicz
Modified:
3 years, 5 months ago
Reviewers:
michaelpg
CC:
chromium-reviews, oshima+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove all calls to domAutomationController.setAutomationId. These calls are no longer needed after r485461 (https://crrev.com/2478803003) which has made the domAutomationController.setAutomationId call a no-op. BUG=662543 This CL was uploaded by git cl split. R=michaelpg@chromium.org Review-Url: https://codereview.chromium.org/2974323003 Cr-Commit-Position: refs/heads/master@{#486638} Committed: https://chromium.googlesource.com/chromium/src/+/c1431083215d32c6af92fa27cbb89d45d6815eda

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M ui/webui/resources/js/webui_resource_test.js View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Łukasz Anforowicz
michaelpg@, can you PTAL?
3 years, 5 months ago (2017-07-11 23:55:12 UTC) #3
michaelpg
lgtm
3 years, 5 months ago (2017-07-13 20:05:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2974323003/1
3 years, 5 months ago (2017-07-14 00:20:01 UTC) #8
commit-bot: I haz the power
3 years, 5 months ago (2017-07-14 02:19:27 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c1431083215d32c6af92fa27cbb8...

Powered by Google App Engine
This is Rietveld 408576698