Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 2974293003: Remove all calls to domAutomationController.setAutomationId. (Closed)

Created:
3 years, 5 months ago by Łukasz Anforowicz
Modified:
3 years, 5 months ago
Reviewers:
achuithb
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove all calls to domAutomationController.setAutomationId. These calls are no longer needed after r485461 (https://crrev.com/2478803003) which has made the domAutomationController.setAutomationId call a no-op. BUG=662543 This CL was uploaded by git cl split. R=xiyuan@chromium.org Review-Url: https://codereview.chromium.org/2974293003 Cr-Commit-Position: refs/heads/master@{#485804} Committed: https://chromium.googlesource.com/chromium/src/+/e8fe6202113dc984079de2d8de7403eed9d7ab4e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -16 lines) Patch
M chrome/browser/chromeos/login/enterprise_enrollment_browsertest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/kiosk_browsertest.cc View 5 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/login_browsertest.cc View 3 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/saml/saml_browsertest.cc View 5 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/test/oobe_base_test.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
Łukasz Anforowicz
achuith@, could you PTAL?
3 years, 5 months ago (2017-07-11 21:56:08 UTC) #4
achuithb
On 2017/07/11 21:56:08, Łukasz A. wrote: > achuith@, could you PTAL? Could you run this ...
3 years, 5 months ago (2017-07-11 22:06:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2974293003/1
3 years, 5 months ago (2017-07-12 02:16:07 UTC) #9
commit-bot: I haz the power
3 years, 5 months ago (2017-07-12 02:29:41 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e8fe6202113dc984079de2d8de74...

Powered by Google App Engine
This is Rietveld 408576698