Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Unified Diff: milo/buildsource/buildbot/buildinfo_test.go

Issue 2974263002: [milo] better ACL system for masters. (Closed)
Patch Set: fix tests Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: milo/buildsource/buildbot/buildinfo_test.go
diff --git a/milo/buildsource/buildbot/buildinfo_test.go b/milo/buildsource/buildbot/buildinfo_test.go
index cf1320673519403942e30f616bac0533f16dc3c8..af0dfab1f6f4f8370f01973ea01d9f5ff9a3052b 100644
--- a/milo/buildsource/buildbot/buildinfo_test.go
+++ b/milo/buildsource/buildbot/buildinfo_test.go
@@ -114,6 +114,9 @@ func TestBuildInfo(t *testing.T) {
},
}
+ // mark foo master as public
+ So(ds.Put(c, &buildbotMasterPublic{"foo master"}), ShouldBeNil)
+
logdogStep := miloProto.Step{
Command: &miloProto.Step_Command{
CommandLine: []string{"foo", "bar", "baz"},
@@ -141,7 +144,8 @@ func TestBuildInfo(t *testing.T) {
BuilderName: "bar builder",
BuildNumber: 1334,
}, "")
- So(err.Error(), ShouldResemble, "rpc error: code = Unauthenticated desc = ")
+ So(err, ShouldErrLike,
+ "rpc error: code = NotFound desc = Build #1334 for master \"foo master\", builder \"bar builder\" was not found")
})
Convey("Can load a BuildBot build by log location.", func() {

Powered by Google App Engine
This is Rietveld 408576698