[milo] better ACL system for masters.

milo/buildsource/buildbot/buildinfo_test.go

 // Copyright 2017 The LUCI Authors. All rights reserved.
 // Use of this source code is governed under the Apache License, Version 2.0
 // that can be found in the LICENSE file.
 
 package buildbot
 
 import (
         "testing"
 
         miloProto "github.com/luci/luci-go/common/proto/milo"
@@ skipping 96 matching lines @@
                 build := buildbotBuild{
                         Master:      "foo master",
                         Buildername: "bar builder",
                         Number:      1337,
                         Properties: []*buildbotProperty{
                                 {Name: "foo", Value: "build-foo"},
                                 {Name: "bar", Value: "build-bar"},
                         },
                 }
 
+                // mark foo master as public
+                So(ds.Put(c, &buildbotMasterPublic{"foo master"}), ShouldBeNil)
+
                 logdogStep := miloProto.Step{
                         Command: &miloProto.Step_Command{
                                 CommandLine: []string{"foo", "bar", "baz"},
                         },
                         Text: []string{"test step"},
                         Property: []*miloProto.Step_Property{
                                 {Name: "bar", Value: "log-bar"},
                         },
                 }
 
                 biReq := milo.BuildInfoRequest{
                         Build: &milo.BuildInfoRequest_Buildbot{
                                 Buildbot: &milo.BuildInfoRequest_BuildBot{
                                         MasterName:  "foo master",
                                         BuilderName: "bar builder",
                                         BuildNumber: 1337,
                                 },
                         },
                 }
 
                 Convey("Load an invalid build", func() {
                         _, err := bip.GetBuildInfo(c,
                                 &milo.BuildInfoRequest_BuildBot{
                                         MasterName:  "foo master",
                                         BuilderName: "bar builder",
                                         BuildNumber: 1334,
                                 }, "")
-                        So(err.Error(), ShouldResemble, "rpc error: code = Unauthenticated desc = ")
+                        So(err, ShouldErrLike,
+                                "rpc error: code = NotFound desc = Build #1334 for master \"foo master\", builder \"bar builder\" was not found")
                 })
 
                 Convey("Can load a BuildBot build by log location.", func() {
                         build.Properties = append(build.Properties, []*buildbotProperty{
                                 {Name: "log_location", Value: "logdog://example.com/testproject/foo/bar/+/baz/annotations"},
                         }...)
                         So(ds.Put(c, &build), ShouldBeNil)
                         testClient.resp = []interface{}{
                                 datagramGetResponse("testproject", "foo/bar", &logdogStep),
                         }
@@ skipping 212 matching lines @@
                                 },
                                 AnnotationStream: &miloProto.LogdogStream{
                                         Server: "example.com",
                                         Prefix: "bb/foo_master/bar_builder/1337",
                                         Name:   "annotations",
                                 },
                         })
                 })
         })
 }