Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(602)

Issue 2974243002: Revert of Added experiments section and exported the list of SafeBrowsing features in WebUI (Closed)

Created:
3 years, 5 months ago by Peter Wen
Modified:
3 years, 5 months ago
CC:
chromium-reviews, vakh+watch_chromium.org, droger+watchlist_chromium.org, grt+watch_chromium.org, sdefresne+watchlist_chromium.org, timvolodine, oshima+watch_chromium.org, blundell+watchlist_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Added experiments section and exported the list of SafeBrowsing features in WebUI (patchset #12 id:220001 of https://codereview.chromium.org/2964693003/ ) Reason for revert: Introduced new static initializer: https://crbug.com/740955 Original issue's description: > -Added the experimental features section as part of the chrome://safe-browsing. For the experiments not running at 100%. > > -Exported the list of SafeBrowsing features (base::Feature) to have them in the future in a central location. > > -Fixed the message dialogue for the WebUI. > > -Added some extra css. > > Note: Tags for the experiments are not added in this issue. > Review-Url: https://codereview.chromium.org/2964693003 > Cr-Commit-Position: refs/heads/master@{#485380} > Committed: https://chromium.googlesource.com/chromium/src/+/fdacb19a2600b6ca47c7d58752a97bc075fd89f5 TBR=jialiul@chromium.org,vakh@chromium.org,blundell@chromium.org,tommycli@chromium.org,pkasting@chromium.org,hkamila@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2974243002 Cr-Commit-Position: refs/heads/master@{#485651} Committed: https://chromium.googlesource.com/chromium/src/+/74a5941b8bc410ce79a0d6f1ac8faa166e931f5d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -239 lines) Patch
M chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/safe_browsing/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/safe_browsing/threat_dom_details_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/resources/safe_browsing_resources.grdp View 1 chunk +0 lines, -1 line 0 comments Download
M components/safe_browsing/BUILD.gn View 2 chunks +0 lines, -12 lines 0 comments Download
D components/safe_browsing/features.h View 1 chunk +0 lines, -29 lines 0 comments Download
D components/safe_browsing/features.cc View 1 chunk +0 lines, -68 lines 0 comments Download
M components/safe_browsing/renderer/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/safe_browsing/renderer/DEPS View 1 chunk +1 line, -2 lines 0 comments Download
M components/safe_browsing/renderer/threat_dom_details.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/safe_browsing/renderer/threat_dom_details.cc View 2 chunks +9 lines, -1 line 0 comments Download
M components/safe_browsing/web_ui/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/safe_browsing/web_ui/resources/safe_browsing.css View 1 chunk +1 line, -22 lines 0 comments Download
M components/safe_browsing/web_ui/resources/safe_browsing.html View 1 chunk +1 line, -8 lines 0 comments Download
D components/safe_browsing/web_ui/resources/safe_browsing.js View 1 chunk +0 lines, -29 lines 0 comments Download
M components/safe_browsing/web_ui/safe_browsing_ui.h View 2 chunks +4 lines, -24 lines 0 comments Download
M components/safe_browsing/web_ui/safe_browsing_ui.cc View 3 chunks +3 lines, -32 lines 0 comments Download
M components/safe_browsing_db/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/safe_browsing_db/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M components/safe_browsing_db/v4_feature_list.cc View 2 chunks +12 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
Peter Wen
Created Revert of Added experiments section and exported the list of SafeBrowsing features in WebUI
3 years, 5 months ago (2017-07-11 16:39:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2974243002/1
3 years, 5 months ago (2017-07-11 16:39:56 UTC) #3
commit-bot: I haz the power
3 years, 5 months ago (2017-07-11 16:41:04 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/74a5941b8bc410ce79a0d6f1ac8f...

Powered by Google App Engine
This is Rietveld 408576698