Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(943)

Unified Diff: runtime/vm/assembler_ia32.h

Issue 2974233002: VM: Re-format to use at most one newline between functions (Closed)
Patch Set: Rebase and merge Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/assembler_dbc_test.cc ('k') | runtime/vm/assembler_ia32.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/assembler_ia32.h
diff --git a/runtime/vm/assembler_ia32.h b/runtime/vm/assembler_ia32.h
index 993da0aa0b0418beadda1bcbc19598a016da3320..299ba2a7ffd1085dc238a529c628525c39e125e4 100644
--- a/runtime/vm/assembler_ia32.h
+++ b/runtime/vm/assembler_ia32.h
@@ -39,7 +39,6 @@ class Immediate : public ValueObject {
// And remove the unnecessary copy constructor.
};
-
class Operand : public ValueObject {
public:
uint8_t mod() const { return (encoding_at(0) >> 6) & 3; }
@@ -135,7 +134,6 @@ class Operand : public ValueObject {
friend class Assembler;
};
-
class Address : public Operand {
public:
Address(Register base, int32_t disp) {
@@ -200,7 +198,6 @@ class Address : public Operand {
Address() {} // Needed by Address::Absolute.
};
-
class FieldAddress : public Address {
public:
FieldAddress(Register base, int32_t disp)
@@ -223,7 +220,6 @@ class FieldAddress : public Address {
}
};
-
class Label : public ValueObject {
public:
Label() : position_(0), unresolved_(0) {
@@ -292,7 +288,6 @@ class Label : public ValueObject {
DISALLOW_COPY_AND_ASSIGN(Label);
};
-
class Assembler : public ValueObject {
public:
explicit Assembler(bool use_far_branches = false)
@@ -941,7 +936,6 @@ class Assembler : public ValueObject {
DISALLOW_COPY_AND_ASSIGN(CodeComment);
};
-
inline void EmitUint8(uint8_t value);
inline void EmitInt32(int32_t value);
inline void EmitRegisterOperand(int rm, int reg);
@@ -980,33 +974,27 @@ class Assembler : public ValueObject {
DISALLOW_COPY_AND_ASSIGN(Assembler);
};
-
inline void Assembler::EmitUint8(uint8_t value) {
buffer_.Emit<uint8_t>(value);
}
-
inline void Assembler::EmitInt32(int32_t value) {
buffer_.Emit<int32_t>(value);
}
-
inline void Assembler::EmitRegisterOperand(int rm, int reg) {
ASSERT(rm >= 0 && rm < 8);
buffer_.Emit<uint8_t>(0xC0 + (rm << 3) + reg);
}
-
inline void Assembler::EmitXmmRegisterOperand(int rm, XmmRegister reg) {
EmitRegisterOperand(rm, static_cast<Register>(reg));
}
-
inline void Assembler::EmitFixup(AssemblerFixup* fixup) {
buffer_.EmitFixup(fixup);
}
-
inline void Assembler::EmitOperandSizeOverride() {
EmitUint8(0x66);
}
« no previous file with comments | « runtime/vm/assembler_dbc_test.cc ('k') | runtime/vm/assembler_ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698