Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5845)

Unified Diff: chrome/browser/ui/webui/print_preview/print_preview_handler.h

Issue 2974183002: Remove bad CallJavascriptFunctionUnsafe call from PrintPreviewUI (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/print_preview/print_preview_handler.h
diff --git a/chrome/browser/ui/webui/print_preview/print_preview_handler.h b/chrome/browser/ui/webui/print_preview/print_preview_handler.h
index 34725e3ab04c4df43c1687b63a2bc422dd10ec5f..c79dd4b690db72ef36ba1af969b7cf8177015713 100644
--- a/chrome/browser/ui/webui/print_preview/print_preview_handler.h
+++ b/chrome/browser/ui/webui/print_preview/print_preview_handler.h
@@ -116,6 +116,9 @@ class PrintPreviewHandler
// Sets |pdf_file_saved_closure_| to |closure|.
void SetPdfSavedClosureForTesting(const base::Closure& closure);
+ // Handles the request to cancel the pending print request. |args| is unused.
+ void HandleCancelPendingPrintRequest(const base::ListValue* args);
Lei Zhang 2017/07/11 22:34:20 Can we keep this methods protected, and add a new
rbpotter 2017/07/12 00:26:35 Done.
+
protected:
// If |prompt_user| is true, starts a task to create the default Save As PDF
// directory if needed. OnDirectoryCreated() will be called when it
@@ -167,9 +170,6 @@ class PrintPreviewHandler
// |args| is unused.
void HandleHidePreview(const base::ListValue* args);
- // Handles the request to cancel the pending print request. |args| is unused.
- void HandleCancelPendingPrintRequest(const base::ListValue* args);
-
// Handles a request to store data that the web ui wishes to persist.
// First element of |args| is the data to persist.
void HandleSaveAppState(const base::ListValue* args);
« no previous file with comments | « chrome/browser/printing/background_printing_manager.cc ('k') | chrome/browser/ui/webui/print_preview/print_preview_ui.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698