Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(822)

Unified Diff: build/android/test_runner.py

Issue 2974163002: Fix the stack script issue when symbolizing tombstones. (Closed)
Patch Set: add unziped so files as packed-lib Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/android/tombstones.py » ('j') | build/android/tombstones.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/test_runner.py
diff --git a/build/android/test_runner.py b/build/android/test_runner.py
index 835888b02a16a9a11cec9f042f678f9a60149ebd..dcddf5f9bf4e688a942432702642e611ccc7d7f0 100755
--- a/build/android/test_runner.py
+++ b/build/android/test_runner.py
@@ -14,6 +14,7 @@ import logging
import os
import shutil
import signal
+import subprocess
import sys
import threading
import traceback
@@ -786,6 +787,12 @@ def RunTestsInPlatformMode(args):
upload_logcats_file(),
'upload_logcats_file' in args and args.upload_logcats_file)
+ if 'apk_under_test' in args and args.apk_under_test:
+ subprocess.check_call(
+ 'unzip -o %s -d %s' % (args.apk_under_test,
+ constants.GetOutDirectory()),
+ shell=True)
mikecase (-- gone --) 2017/07/11 21:42:01 Would it make more sense for the stack/tombstone s
jbudorick 2017/07/12 20:57:28 We had discussed doing the latter last week, w/ th
BigBossZhiling 2017/07/17 06:42:58 I just added the unzip logic in tombstones.py, bec
+
### Set up test objects.
env = environment_factory.CreateEnvironment(args, infra_error)
« no previous file with comments | « no previous file | build/android/tombstones.py » ('j') | build/android/tombstones.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698