Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2552)

Unified Diff: build/android/tombstones.py

Issue 2974163002: Fix the stack script issue when symbolizing tombstones. (Closed)
Patch Set: add unziped so files as packed-lib Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/android/tombstones.py
diff --git a/build/android/tombstones.py b/build/android/tombstones.py
index dbc6281c2f541af6cde7978be0c12115210379f7..0a8f968afb5fc0ec2b25b24ccf9b9b3852343f9a 100755
--- a/build/android/tombstones.py
+++ b/build/android/tombstones.py
@@ -130,8 +130,15 @@ def _ResolveSymbols(tombstone_data, include_stack, device_abi):
stack_tool = os.path.join(os.path.dirname(__file__), '..', '..',
'third_party', 'android_platform', 'development',
'scripts', 'stack')
+
cmd = [stack_tool, '--arch', arch, '--output-directory',
constants.GetOutDirectory()]
+ if os.path.exists(os.path.join(constants.GetOutDirectory(), 'lib')):
+ for root, _, files in os.walk(os.path.join(constants.GetOutDirectory(),
+ 'lib')):
+ for file_name in files:
+ if file_name.endswith('.so'):
+ cmd.extend(['--packed-lib', os.path.join(root, file_name)])
jbudorick 2017/07/12 20:57:28 --packed-lib implies that the library has had its
BigBossZhiling 2017/07/17 06:42:58 unstripped libs will always be there now in isolat
proc = subprocess.Popen(cmd, stdin=subprocess.PIPE, stdout=subprocess.PIPE)
output = proc.communicate(input='\n'.join(tombstone_data))[0]
for line in output.split('\n'):

Powered by Google App Engine
This is Rietveld 408576698