Fix the stack script issue when symbolizing tombstones.

build/android/test_runner.py

 #!/usr/bin/env python
 #
 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Runs all types of tests from one unified interface."""
 
 import argparse
 import collections
 import contextlib
 import itertools
 import logging
 import os
 import shutil
 import signal
+import subprocess
 import sys
 import threading
 import traceback
 import unittest
 
 # Import _strptime before threaded code. datetime.datetime.strptime is
 # threadsafe except for the initial import of the _strptime module.
 # See http://crbug.com/724524 and https://bugs.python.org/issue7980.
 import _strptime  # pylint: disable=unused-import
 
@@ skipping 752 matching lines @@
             shutil.copyfileobj(src, dst)
             dst.close()
             logging.critical(
                 'Logcat: %s', logdog_helper.get_viewer_url('unified_logcats'))
 
 
   logcats_uploader = contextlib_ext.Optional(
       upload_logcats_file(),
       'upload_logcats_file' in args and args.upload_logcats_file)
 
+  if 'apk_under_test' in args and args.apk_under_test:
+    subprocess.check_call(
+        'unzip -o %s -d %s' % (args.apk_under_test,
+                               constants.GetOutDirectory()),
+        shell=True)

[mikecase (-- gone --), 2017/07/11 21:42:01]

Would it make more sense for the stack/tombstone script to unzip the APK. That
way the unzipped APK is used closer to where it is unzipped? idk, suggestion.

Or maybe unzip the APK just before running the tombstone script?

[jbudorick, 2017/07/12 20:57:28]

We had discussed doing the latter last week, w/ the discussion about lazy
unzipping. Please look at doing so.

[BigBossZhiling, 2017/07/17 06:42:58]

I just added the unzip logic in tombstones.py, because the unzip logic always
will be called at the same time when we want to resolve tombstones. Or do you
think I should put it into instrumentation test run?

+
   ### Set up test objects.
 
   env = environment_factory.CreateEnvironment(args, infra_error)
   test_instance = test_instance_factory.CreateTestInstance(args, infra_error)
   test_run = test_run_factory.CreateTestRun(
       args, env, test_instance, infra_error)
 
   ### Run.
 
   with json_writer, logcats_uploader, env, test_instance, test_run:
@@ skipping 138 matching lines @@
     if e.is_infra_error:
       return constants.INFRA_EXIT_CODE
     return constants.ERROR_EXIT_CODE
   except: # pylint: disable=W0702
     logging.exception('Unrecognized error occurred.')
     return constants.ERROR_EXIT_CODE
 
 
 if __name__ == '__main__':
   sys.exit(main())