Create a maintenance mutex skeleton within luci-go

Create a maintenance mutex skeleton within luci-go

BUG=416072
Review-Url: https://codereview.chromium.org/2974113002
Committed: https://github.com/luci/luci-go/commit/51e30bd208ab3463dd0690ffd0c40403d93912f1

[charliea (OOO until 10-5), 2017-07-10 19:18:59]

Patchset #1 (id:1) has been deleted

[charliea (OOO until 10-5), 2017-07-10 19:19:07]

Patchset #1 (id:20001) has been deleted

[charliea (OOO until 10-5), 2017-07-10 19:19:25]

charliea@chromium.org changed reviewers:
+ iannucci@chromium.org

[charliea (OOO until 10-5), 2017-07-10 19:22:14]

Patchset #1 (id:40001) has been deleted

[iannucci, 2017-07-10 19:40:23]

lgtm w/ comments

https://codereview.chromium.org/2974113002/diff/60001/maintenancemutex/README.md
File maintenancemutex/README.md (right):

https://codereview.chromium.org/2974113002/diff/60001/maintenancemutex/README...
maintenancemutex/README.md:1: maintenancemutex
rename the folder to 'mmutex' and have the README title look like

  Maintenance Mutex (mmutex)

https://codereview.chromium.org/2974113002/diff/60001/maintenancemutex/README...
maintenancemutex/README.md:5: from running during performance sensitive tasks.
s/performance sensitive/user everywhere

https://codereview.chromium.org/2974113002/diff/60001/maintenancemutex/README...
maintenancemutex/README.md:8: tasks from being run while potentially expensive
system maintenance tasks are
s/potentially expensive//

The point of the tool is to make all user and maintenance tasks mutually
exclusive (regardless of performance).

https://codereview.chromium.org/2974113002/diff/60001/maintenancemutex/README...
maintenancemutex/README.md:11: Clients can use this tool to request that their
task be scheduled with one of
s/scheduled/run

There's no 'deferral' happening in the tool, so 'run' is more direct than
'schedule'

https://codereview.chromium.org/2974113002/diff/60001/maintenancemutex/README...
maintenancemutex/README.md:27: opportunity to do so, at which point the global
drain file is deleted.
this paragraph might be a bit too detailed for a README, but not detailed enough
for an implementation doc. Consider having a separate md which details the
protocol.

https://codereview.chromium.org/2974113002/diff/60001/maintenancemutex/cmd/ma...
File maintenancemutex/cmd/main.go (right):

https://codereview.chromium.org/2974113002/diff/60001/maintenancemutex/cmd/ma...
maintenancemutex/cmd/main.go:1: // Copyright 2017 The LUCI Authors. All rights
reserved.
put this in a subfolder '//mmutex/cmd/mmutex', or go will compile this to an
executable called 'main'

https://codereview.chromium.org/2974113002/diff/60001/maintenancemutex/cmd/ma...
maintenancemutex/cmd/main.go:5: package cmd
main packages always have the package 'main'

[charliea (OOO until 10-5), 2017-07-10 19:56:50]

https://codereview.chromium.org/2974113002/diff/60001/maintenancemutex/README.md
File maintenancemutex/README.md (right):

https://codereview.chromium.org/2974113002/diff/60001/maintenancemutex/README...
maintenancemutex/README.md:1: maintenancemutex
On 2017/07/10 19:40:23, iannucci wrote:
> rename the folder to 'mmutex' and have the README title look like
> 
>   Maintenance Mutex (mmutex)

Done.

https://codereview.chromium.org/2974113002/diff/60001/maintenancemutex/README...
maintenancemutex/README.md:5: from running during performance sensitive tasks.
On 2017/07/10 19:40:23, iannucci wrote:
> s/performance sensitive/user everywhere

Done.

https://codereview.chromium.org/2974113002/diff/60001/maintenancemutex/README...
maintenancemutex/README.md:8: tasks from being run while potentially expensive
system maintenance tasks are
On 2017/07/10 19:40:22, iannucci wrote:
> s/potentially expensive//
> 
> The point of the tool is to make all user and maintenance tasks mutually
> exclusive (regardless of performance).

Done.

https://codereview.chromium.org/2974113002/diff/60001/maintenancemutex/README...
maintenancemutex/README.md:11: Clients can use this tool to request that their
task be scheduled with one of
On 2017/07/10 19:40:23, iannucci wrote:
> s/scheduled/run
> 
> There's no 'deferral' happening in the tool, so 'run' is more direct than
> 'schedule'

Done.

https://codereview.chromium.org/2974113002/diff/60001/maintenancemutex/README...
maintenancemutex/README.md:27: opportunity to do so, at which point the global
drain file is deleted.
On 2017/07/10 19:40:23, iannucci wrote:
> this paragraph might be a bit too detailed for a README, but not detailed
enough
> for an implementation doc. Consider having a separate md which details the
> protocol.

SGTM. I deleted it for now and will revisit whether it's necessary again in the
future.

https://codereview.chromium.org/2974113002/diff/60001/maintenancemutex/cmd/ma...
File maintenancemutex/cmd/main.go (right):

https://codereview.chromium.org/2974113002/diff/60001/maintenancemutex/cmd/ma...
maintenancemutex/cmd/main.go:1: // Copyright 2017 The LUCI Authors. All rights
reserved.
On 2017/07/10 19:40:23, iannucci wrote:
> put this in a subfolder '//mmutex/cmd/mmutex', or go will compile this to an
> executable called 'main'

Done.

https://codereview.chromium.org/2974113002/diff/60001/maintenancemutex/cmd/ma...
maintenancemutex/cmd/main.go:5: package cmd
On 2017/07/10 19:40:23, iannucci wrote:
> main packages always have the package 'main'

Done.

[charliea (OOO until 10-5), 2017-07-10 19:57:05]

The CQ bit was checked by charliea@chromium.org

[charliea (OOO until 10-5), 2017-07-10 19:57:06]

The patchset sent to the CQ was uploaded after l-g-t-m from
iannucci@chromium.org
Link to the patchset: https://codereview.chromium.org/2974113002/#ps80001
(title: "")

[commit-bot: I haz the power, 2017-07-10 19:57:13]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[charliea (OOO until 10-5), 2017-07-10 20:02:20]

Description was changed from

==========
Create a maintenancemutex skeleton within luci-go

BUG=416072
==========

to

==========
Create a maintenance mutex skeleton within luci-go

BUG=416072
==========

[commit-bot: I haz the power, 2017-07-10 20:06:02]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1499716625775150,
"parent_rev": "48dd1818b5e5ea8debff6ef2fb5fbb86291be985", "commit_rev":
"51e30bd208ab3463dd0690ffd0c40403d93912f1"}

[commit-bot: I haz the power, 2017-07-10 20:06:07]

Description was changed from

==========
Create a maintenance mutex skeleton within luci-go

BUG=416072
==========

to

==========
Create a maintenance mutex skeleton within luci-go

BUG=416072

Review-Url: https://codereview.chromium.org/2974113002
Committed:
https://github.com/luci/luci-go/commit/51e30bd208ab3463dd0690ffd0c40403d93912f1
==========

[commit-bot: I haz the power, 2017-07-10 20:06:08]

Committed patchset #2 (id:80001) as
https://github.com/luci/luci-go/commit/51e30bd208ab3463dd0690ffd0c40403d93912f1