Remove requirement that USB printers have a make/model metadata

Remove requirement that USB printers have a make and model in their
metadata.  We don't *actually* need this information for anything
other than usage tracking, and having these printers actually *work*
is more important that getting good metadata about them.

BUG=

Review-Url: https://codereview.chromium.org/2974103002
Cr-Commit-Position: refs/heads/master@{#485428}
Committed: https://chromium.googlesource.com/chromium/src/+/a6fb014f8fb2ae32d8908a28e1e8b7b57194dde3

[Carlson, 2017-07-10 18:33:11]

The CQ bit was checked by justincarlson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-10 18:33:21]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Carlson, 2017-07-10 18:38:46]

justincarlson@chromium.org changed reviewers:
+ skau@chromium.org

[Carlson, 2017-07-10 18:39:02]

Description was changed from

==========
Remove requirement that USB printers have a make and model in their
metadata.  We don't *actually* need this information for anything
other than usage tracking, and having these printers actually *work*
is more important that getting good metadata about them.

BUG=
==========

to

==========
Remove requirement that USB printers have a make and model in their
metadata.  We don't *actually* need this information for anything
other than usage tracking, and having these printers actually *work*
is more important that getting good metadata about them.

BUG=
==========

[commit-bot: I haz the power, 2017-07-10 19:10:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-10 19:10:36]

Dry run: This issue passed the CQ dry run.

[skau, 2017-07-10 21:24:18]

lgtm

https://codereview.chromium.org/2974103002/diff/1/chrome/browser/chromeos/pri...
File chrome/browser/chromeos/printing/usb_printer_util.cc (right):

https://codereview.chromium.org/2974103002/diff/1/chrome/browser/chromeos/pri...
chrome/browser/chromeos/printing/usb_printer_util.cc:157: <<
UsbPrinterDeviceDetailsAsString(device);
I would just skip the log.  We should be pretty tolerant of empty fields.  Of
course, test it to make sure that's true (I can't remember)

[xiaochu, 2017-07-10 21:27:00]

xiaochu@chromium.org changed reviewers:
+ xiaochu@chromium.org

[xiaochu, 2017-07-10 21:27:00]

Thanks!

[Carlson, 2017-07-10 21:32:02]

https://codereview.chromium.org/2974103002/diff/1/chrome/browser/chromeos/pri...
File chrome/browser/chromeos/printing/usb_printer_util.cc (right):

https://codereview.chromium.org/2974103002/diff/1/chrome/browser/chromeos/pri...
chrome/browser/chromeos/printing/usb_printer_util.cc:157: <<
UsbPrinterDeviceDetailsAsString(device);
On 2017/07/10 21:24:18, skau wrote:
> I would just skip the log.  We should be pretty tolerant of empty fields.  Of
> course, test it to make sure that's true (I can't remember)

Added some logic to make the display name less cryptic if we have neither make
nor model, removed the log.

[Carlson, 2017-07-10 21:42:10]

The CQ bit was checked by justincarlson@chromium.org

[Carlson, 2017-07-10 21:42:11]

The patchset sent to the CQ was uploaded after l-g-t-m from skau@chromium.org
Link to the patchset: https://codereview.chromium.org/2974103002/#ps40001
(title: "Moar better naming logic to prevent spurios extra spaces in some
cases"")

[commit-bot: I haz the power, 2017-07-10 21:42:28]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-10 22:37:17]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1499722930803570,
"parent_rev": "038548bf0ea65235ee6cb2d0b24ce9b1c111dbd9", "commit_rev":
"a6fb014f8fb2ae32d8908a28e1e8b7b57194dde3"}

[commit-bot: I haz the power, 2017-07-10 22:37:32]

Description was changed from

==========
Remove requirement that USB printers have a make and model in their
metadata.  We don't *actually* need this information for anything
other than usage tracking, and having these printers actually *work*
is more important that getting good metadata about them.

BUG=
==========

to

==========
Remove requirement that USB printers have a make and model in their
metadata.  We don't *actually* need this information for anything
other than usage tracking, and having these printers actually *work*
is more important that getting good metadata about them.

BUG=

Review-Url: https://codereview.chromium.org/2974103002
Cr-Commit-Position: refs/heads/master@{#485428}
Committed:
https://chromium.googlesource.com/chromium/src/+/a6fb014f8fb2ae32d8908a28e1e8...
==========

[commit-bot: I haz the power, 2017-07-10 22:37:34]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/a6fb014f8fb2ae32d8908a28e1e8...