Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issue 2973983002: Revert of [Media Router] Add CastMediaSinkService (Closed)

Created:
3 years, 5 months ago by Bret
Modified:
3 years, 5 months ago
CC:
Aaron Boodman, abarth-chromium, chfremer+watch_chromium.org, chromium-reviews, darin (slow to review), feature-media-reviews_chromium.org, imcheng+watch_chromium.org, mfoltz+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Media Router] Add CastMediaSinkService (patchset #11 id:200001 of https://codereview.chromium.org/2927833002/ ) Reason for revert: Causing unit_tests failures on multiple bots For example: https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.9%20Tests/builds/44050 https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.10%20Tests/builds/20527 https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20TSan%20Tests/builds/8549 Original issue's description: > [Media Router] Add CastMediaSinkService > > NOTE: those extensions header files and extensions::api:: namespace will go away when https://codereview.chromium.org/2913033003/ lands > > Discover process is similar to DialMediaSinkService: > - CastMediaSinkService::Start() registers itself with DnsRegistry > - CastMediaSinkService::OnDnsSdEvent() gets invoked when Dns services comes back and starts a 3s timer > - Start opening channel for each service on IO thread > - CastMediaSinkService::OnChannelOpenedOnIOThread() gets invoked when channel open finishes > - Post task back to UI thread via CastMediaSinkService::OnChannelOpenOnUIThread() > - Create MediaSinkInternal and store it in CastSinkService's sink map > - Invoke MediaSinkBase::FetchCompleted() and send sinks to MRP when timer expires > > TODO: > Unit test > Implement CastSocketService::OpenChannel > > BUG=687377 > > Review-Url: https://codereview.chromium.org/2927833002 > Cr-Commit-Position: refs/heads/master@{#484979} > Committed: https://chromium.googlesource.com/chromium/src/+/b9a2a9b60034d3ee2138c4815bc3c66b13cee3b5 TBR=mfoltz@chromium.org,imcheng@chromium.org,zhaobin@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=687377 Review-Url: https://codereview.chromium.org/2973983002 Cr-Commit-Position: refs/heads/master@{#484996} Committed: https://chromium.googlesource.com/chromium/src/+/989a05a98d9d8a1dbd1bec1d943e2456e395e671

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -725 lines) Patch
M chrome/browser/media/router/discovery/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
D chrome/browser/media/router/discovery/mdns/cast_media_sink_service.h View 1 chunk +0 lines, -132 lines 0 comments Download
D chrome/browser/media/router/discovery/mdns/cast_media_sink_service.cc View 1 chunk +0 lines, -245 lines 0 comments Download
D chrome/browser/media/router/discovery/mdns/cast_media_sink_service_unittest.cc View 1 chunk +0 lines, -309 lines 0 comments Download
M chrome/browser/media/router/discovery/mdns/mock_dns_sd_registry.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media/router/mojo/media_router_mojo_impl.h View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/media/router/mojo/media_router_mojo_impl.cc View 4 chunks +12 lines, -23 lines 0 comments Download
M chrome/test/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/cast_channel/cast_socket_service.h View 3 chunks +6 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
Bret
Created Revert of [Media Router] Add CastMediaSinkService
3 years, 5 months ago (2017-07-07 18:36:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2973983002/1
3 years, 5 months ago (2017-07-07 18:37:11 UTC) #3
commit-bot: I haz the power
3 years, 5 months ago (2017-07-07 18:38:24 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/989a05a98d9d8a1dbd1bec1d943e...

Powered by Google App Engine
This is Rietveld 408576698