third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp - Issue 2973973002: Implement AccessibleNode.hasPopUp for Accessibility Object Model phase 1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp

Issue 2973973002: Implement AccessibleNode.hasPopUp for Accessibility Object Model phase 1 (Closed)

Patch Set: Fix handling of aria-haspopup=false Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp

diff --git a/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp b/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp

index a0d2f7aed90610ef88098ffcf3d115d1523211d4..3868b615a8121a9c22891ae1b84024b51d9a026e 100644

--- a/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp

+++ b/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp

@@ -1279,7 +1279,11 @@ void AXLayoutObject::AriaLabelledbyElements(AXObjectVector& labelledby) const {

}

bool AXLayoutObject::AriaHasPopup() const {

- return ElementAttributeValue(aria_haspopupAttr);

+ const AtomicString& has_popup =

+ GetAOMPropertyOrARIAAttribute(AOMStringProperty::kHasPopUp);

+ return !has_popup.IsNull() && !has_popup.IsEmpty() &&

+ !EqualIgnoringASCIICase(has_popup, "false");

}

bool AXLayoutObject::AriaRoleHasPresentationalChildren() const {