Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 2973943002: [kernel] Allow reflection on some fields; add metadata on fields too. (Closed)

Created:
3 years, 5 months ago by jensj
Modified:
3 years, 5 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[kernel] Allow reflection on some fields; add metadata on fields too. BUG= R=vegorov@google.com Committed: https://github.com/dart-lang/sdk/commit/fa1cf9e404f83f2ccfd8dad8ad4afd8395f121bd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -29 lines) Patch
M runtime/vm/kernel_reader.cc View 3 chunks +12 lines, -3 lines 0 comments Download
M tests/co19/co19-kernel.status View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/lib/lib.status View 9 chunks +3 lines, -24 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 5 (2 generated)
jensj
I don't know why this was just set to "false" before (for class fields, calling ...
3 years, 5 months ago (2017-07-07 12:25:52 UTC) #2
Vyacheslav Egorov (Google)
lgtm
3 years, 5 months ago (2017-07-07 12:47:35 UTC) #3
jensj
3 years, 5 months ago (2017-07-11 08:11:16 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
fa1cf9e404f83f2ccfd8dad8ad4afd8395f121bd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698