[kernel] Allow reflection on some fields; add metadata on fields too.

runtime/vm/kernel_reader.cc

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/kernel_reader.h"
 
 #include <string.h>
 
 #include "vm/dart_api_impl.h"
 #include "vm/kernel_binary.h"
@@ skipping 265 matching lines @@
                                     field_helper.IsConst(), script_class,
                                     field_helper.position_));
     field.set_kernel_offset(field_offset);
     const AbstractType& type = T.BuildType();  // read type.
     field.SetFieldType(type);
     field_helper.SetJustRead(FieldHelper::kType);
     field_helper.ReadUntilExcluding(FieldHelper::kInitializer);
     field.set_has_initializer(builder_.PeekTag() == kSomething);
     GenerateFieldAccessors(toplevel_class, field, &field_helper, field_offset);
     field_helper.ReadUntilExcluding(FieldHelper::kEnd);
+    if (FLAG_enable_mirrors) {
+      library.AddFieldMetadata(field, TokenPosition::kNoSource, field_offset);
+    }
     fields_.Add(&field);
     library.AddObject(field, name);
   }
   toplevel_class.AddFields(fields_);
 
   // Load toplevel procedures.
   intptr_t procedure_count = builder_.ReadListLength();  // read list length.
   for (intptr_t i = 0; i < procedure_count; ++i) {
     ReadProcedure(library, toplevel_class, false);
   }
@@ skipping 142 matching lines @@
       field_helper.ReadUntilExcluding(FieldHelper::kName);
 
       const dart::String& name = builder_.ReadNameAsFieldName();
       field_helper.SetJustRead(FieldHelper::kName);
       field_helper.ReadUntilExcluding(FieldHelper::kType);
       const AbstractType& type =
           T.BuildTypeWithoutFinalization();  // read type.
       field_helper.SetJustRead(FieldHelper::kType);
       const Object& script_class =
           ClassForScriptAt(klass, field_helper.source_uri_index_);
+
+      const bool is_reflectable =
+          field_helper.position_.IsReal() &&
+          !(library.is_dart_scheme() && library.IsPrivate(name));
       dart::Field& field = dart::Field::Handle(
           Z,
           dart::Field::New(name, field_helper.IsStatic(),
                            // In the VM all const fields are implicitly final
                            // whereas in Kernel they are not final because they
                            // are not explicitly declared that way.
                            field_helper.IsFinal() || field_helper.IsConst(),
-                           field_helper.IsConst(),
-                           false,  // is_reflectable
-                           script_class, type, field_helper.position_));
+                           field_helper.IsConst(), is_reflectable, script_class,
+                           type, field_helper.position_));
       field.set_kernel_offset(field_offset);
       field_helper.ReadUntilExcluding(FieldHelper::kInitializer);
       field.set_has_initializer(builder_.PeekTag() == kSomething);
       GenerateFieldAccessors(klass, field, &field_helper, field_offset);
       field_helper.ReadUntilExcluding(FieldHelper::kEnd);
+      if (FLAG_enable_mirrors) {
+        library.AddFieldMetadata(field, TokenPosition::kNoSource, field_offset);
+      }
       fields_.Add(&field);
     }
     klass.AddFields(fields_);
     class_helper.SetJustRead(ClassHelper::kFields);
   }
 
   class_helper.ReadUntilExcluding(ClassHelper::kConstructors);
   int constructor_count = builder_.ReadListLength();  // read list length.
   for (intptr_t i = 0; i < constructor_count; ++i) {
     intptr_t constructor_offset = builder_.ReaderOffset();
@@ skipping 433 matching lines @@
   initializer_fun.set_is_debuggable(false);
   initializer_fun.set_is_reflectable(false);
   initializer_fun.set_is_inlinable(false);
   return new (zone) ParsedFunction(thread, initializer_fun);
 }
 
 
 }  // namespace kernel
 }  // namespace dart
 #endif  // !defined(DART_PRECOMPILED_RUNTIME)