base/metrics/persistent_histogram_allocator.cc - Issue 2973863002: Remove std::string histogram name from HistogramBase object.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/metrics/persistent_histogram_allocator.cc

Issue 2973863002: Remove std::string histogram name from HistogramBase object.

Patch Set: never rely on outside string permanence Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/metrics/persistent_histogram_allocator.cc

diff --git a/base/metrics/persistent_histogram_allocator.cc b/base/metrics/persistent_histogram_allocator.cc

index 250b74a984fd98d4ad3ca91393b5dbe3745b42a9..a8a4507ae3680db4d1a51b0fdaaf13e233940fc8 100644

--- a/base/metrics/persistent_histogram_allocator.cc

+++ b/base/metrics/persistent_histogram_allocator.cc

@@ -640,7 +640,7 @@ std::unique_ptr<HistogramBase> PersistentHistogramAllocator::CreateHistogram(

/*make_iterable=*/false);

// Create the right type of histogram.

- std::string name(histogram_data_ptr->name);

+ const char* name = histogram_data_ptr->name;

std::unique_ptr<HistogramBase> histogram;

switch (histogram_type) {

case HISTOGRAM: