base/metrics/histogram_snapshot_manager.cc - Issue 2973863002: Remove std::string histogram name from HistogramBase object.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/metrics/histogram_snapshot_manager.cc

Issue 2973863002: Remove std::string histogram name from HistogramBase object.

Patch Set: never rely on outside string permanence Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/metrics/histogram_snapshot_manager.cc

diff --git a/base/metrics/histogram_snapshot_manager.cc b/base/metrics/histogram_snapshot_manager.cc

index 89d4f8ef6fe32a1cae712ff524601b52e6c11d3e..fc8bead72b89f0a24dcb615fc5c2fb0488328989 100644

--- a/base/metrics/histogram_snapshot_manager.cc

+++ b/base/metrics/histogram_snapshot_manager.cc

@@ -81,7 +81,7 @@ void HistogramSnapshotManager::PrepareSamples(

HistogramBase::Sample* ranges_ptr = &ranges_copy[0];

uint32_t ranges_checksum = ranges->checksum();

uint32_t ranges_calc_checksum = ranges->CalculateChecksum();

- const char* histogram_name = histogram->histogram_name().c_str();

+ const char* histogram_name = histogram->histogram_name();

int32_t flags = histogram->flags();

// The checksum should have caught this, so crash separately if it didn't.

CHECK_NE(0U, HistogramBase::RANGE_CHECKSUM_ERROR & corruption);