Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 2973833002: [Sync] Added integ tests to verify UserEvents retry on TRANSIENT_ERROR. (Closed)

Created:
3 years, 5 months ago by skym
Modified:
3 years, 5 months ago
Reviewers:
Patrick Noland
CC:
chromium-reviews, sync-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Added integ tests to verify UserEvents retry on TRANSIENT_ERROR. BUG=728753 Review-Url: https://codereview.chromium.org/2973833002 Cr-Commit-Position: refs/heads/master@{#484939} Committed: https://chromium.googlesource.com/chromium/src/+/0ff047cc8c4e9b8bcadf0ab951781f253afc3a12

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -8 lines) Patch
M chrome/browser/sync/test/integration/single_client_user_events_sync_test.cc View 5 chunks +102 lines, -7 lines 0 comments Download
M components/sync/test/fake_server/fake_server.h View 2 chunks +14 lines, -0 lines 0 comments Download
M components/sync/test/fake_server/fake_server.cc View 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
skym
PTAL
3 years, 5 months ago (2017-07-06 17:22:23 UTC) #3
Patrick Noland
lgtm
3 years, 5 months ago (2017-07-07 00:26:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2973833002/1
3 years, 5 months ago (2017-07-07 15:39:15 UTC) #9
commit-bot: I haz the power
3 years, 5 months ago (2017-07-07 15:47:04 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0ff047cc8c4e9b8bcadf0ab95178...

Powered by Google App Engine
This is Rietveld 408576698