Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 2973763003: Photo Picker dialog: Polish to adhere better to spec. (Closed)

Created:
3 years, 5 months ago by Finnur
Modified:
3 years, 5 months ago
Reviewers:
Theresa
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Photo Picker dialog: Polish to adhere better to spec. Summary of changes: - Change font style for Camera and Browse labels. - Change background color for Camera and Browse tiles from black to light-gray. - Change Camera and Browse tiles to use same background when enabled and disabled. - Change label color for Camera and Browse tiles to dark gray (enabled) and light gray (disabled). - Slightly increase font size for Done button. - Make sure selection ring (on unselected items) shows only in multi-selection. BUG=656015 Review-Url: https://codereview.chromium.org/2973763003 Cr-Commit-Position: refs/heads/master@{#484669} Committed: https://chromium.googlesource.com/chromium/src/+/5a90e1022c20213b0bd1fde0e38724956438a946

Patch Set 1 #

Patch Set 2 : Sync and merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -13 lines) Patch
M chrome/android/java/res/layout/photo_picker_bitmap_view.xml View 1 1 chunk +1 line, -2 lines 0 comments Download
M chrome/android/java/res/layout/photo_picker_toolbar.xml View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/java/res/values/colors.xml View 1 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/photo_picker/PickerBitmapView.java View 1 2 chunks +7 lines, -8 lines 0 comments Download

Messages

Total messages: 18 (14 generated)
Finnur
3 years, 5 months ago (2017-07-06 14:14:48 UTC) #4
Theresa
lgtm
3 years, 5 months ago (2017-07-06 15:32:19 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2973763003/60001
3 years, 5 months ago (2017-07-06 17:11:38 UTC) #15
commit-bot: I haz the power
3 years, 5 months ago (2017-07-06 18:11:33 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/5a90e1022c20213b0bd1fde0e387...

Powered by Google App Engine
This is Rietveld 408576698