Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 2973673003: Use FileNetLogObserver for implementing --log-net-log. (Closed)

Created:
3 years, 5 months ago by eroman
Modified:
3 years, 5 months ago
Reviewers:
mmenke
CC:
chromium-reviews, bnc+watch_chromium.org, eroman
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use FileNetLogObserver for implementing --log-net-log. This has the advantage of moving the file writing off the main thread. BUG=716570 Review-Url: https://codereview.chromium.org/2973673003 Cr-Commit-Position: refs/heads/master@{#485124} Committed: https://chromium.googlesource.com/chromium/src/+/81b0a99860c6fe445637371a5322a468b237fb72

Patch Set 1 #

Patch Set 2 : sigh #

Patch Set 3 : rebase #

Patch Set 4 : test #

Patch Set 5 : check for null #

Total comments: 15

Patch Set 6 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -60 lines) Patch
M chrome/browser/io_thread.cc View 1 2 3 4 5 1 chunk +3 lines, -0 lines 0 comments Download
M components/net_log/chrome_net_log.h View 1 2 3 4 5 4 chunks +32 lines, -6 lines 0 comments Download
M components/net_log/chrome_net_log.cc View 1 2 3 4 5 4 chunks +37 lines, -41 lines 0 comments Download
M components/net_log/net_export_file_writer.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M net/log/file_net_log_observer.h View 1 2 3 2 chunks +5 lines, -7 lines 0 comments Download
M net/log/file_net_log_observer.cc View 1 2 3 1 chunk +12 lines, -5 lines 0 comments Download
M net/log/file_net_log_observer_unittest.cc View 1 2 3 1 chunk +18 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 25 (18 generated)
eroman
3 years, 5 months ago (2017-07-06 18:07:37 UTC) #12
mmenke
https://codereview.chromium.org/2973673003/diff/80001/components/net_log/chrome_net_log.cc File components/net_log/chrome_net_log.cc (right): https://codereview.chromium.org/2973673003/diff/80001/components/net_log/chrome_net_log.cc#newcode89 components/net_log/chrome_net_log.cc:89: void ChromeNetLog::ShutdownBeforeTaskScheduler() { nit: ShutDown* https://codereview.chromium.org/2973673003/diff/80001/components/net_log/chrome_net_log.cc#newcode96 components/net_log/chrome_net_log.cc:96: if (file_net_log_observer_) ...
3 years, 5 months ago (2017-07-06 21:31:30 UTC) #17
eroman
https://codereview.chromium.org/2973673003/diff/80001/components/net_log/chrome_net_log.cc File components/net_log/chrome_net_log.cc (right): https://codereview.chromium.org/2973673003/diff/80001/components/net_log/chrome_net_log.cc#newcode89 components/net_log/chrome_net_log.cc:89: void ChromeNetLog::ShutdownBeforeTaskScheduler() { On 2017/07/06 21:31:29, mmenke wrote: > ...
3 years, 5 months ago (2017-07-06 21:57:55 UTC) #18
mmenke
https://codereview.chromium.org/2973673003/diff/80001/components/net_log/chrome_net_log.h File components/net_log/chrome_net_log.h (right): https://codereview.chromium.org/2973673003/diff/80001/components/net_log/chrome_net_log.h#newcode77 components/net_log/chrome_net_log.h:77: std::unique_ptr<net::FileNetLogObserver> file_net_log_observer_; On 2017/07/06 21:57:54, eroman wrote: > On ...
3 years, 5 months ago (2017-07-06 22:03:48 UTC) #19
mmenke
LGTM
3 years, 5 months ago (2017-07-07 15:39:38 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2973673003/100001
3 years, 5 months ago (2017-07-07 23:58:17 UTC) #22
commit-bot: I haz the power
3 years, 5 months ago (2017-07-08 01:29:58 UTC) #25
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/81b0a99860c6fe445637371a5322...

Powered by Google App Engine
This is Rietveld 408576698