Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Issue 2973643003: Fix remove_webcore_debug_symbols again to avoid constant building (Closed)

Created:
3 years, 5 months ago by brucedawson
Modified:
3 years, 5 months ago
Reviewers:
tkent
CC:
blink-reviews, chromium-reviews, nverne
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix remove_webcore_debug_symbols again to avoid constant building The initial fix to remove_webcore_debug_symbols to make builds clean when using it (crrev.com/2948363004) happened in parallel with a change to add blink_controller (crrev.com/c/547379), so blink_controller didn't use the new pattern, and is therefore always dirty when remove_webcore_debug_symbols is true. This change finishes the fix to make remove_webcore_debug_symbols work properly. R=tkent@chromium.org BUG=647525 Review-Url: https://codereview.chromium.org/2973643003 Cr-Commit-Position: refs/heads/master@{#484672} Committed: https://chromium.googlesource.com/chromium/src/+/961bda534caf2a184153b1458aae16be169bc951

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/controller/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (10 generated)
brucedawson
Minor fix - PTAL.
3 years, 5 months ago (2017-07-06 00:44:31 UTC) #6
brucedawson
Minor fix - PTAL.
3 years, 5 months ago (2017-07-06 00:45:06 UTC) #7
tkent
lgtm
3 years, 5 months ago (2017-07-06 00:52:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2973643003/1
3 years, 5 months ago (2017-07-06 18:08:50 UTC) #12
commit-bot: I haz the power
3 years, 5 months ago (2017-07-06 18:13:56 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/961bda534caf2a184153b1458aae...

Powered by Google App Engine
This is Rietveld 408576698