Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 2973643002: Cache the override for WebRTC's AEC3 in RenderProcessHostImpl (Closed)

Created:
3 years, 5 months ago by hlundin-chromium
Modified:
3 years, 5 months ago
CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, nasko+codewatch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Cache the override for WebRTC's AEC3 in RenderProcessHostImpl If setAudioExperiments is called before the audio track has been created, the value of the AEC3 experiment state should be chached and later used when a track is created. BUG=708475, 739379 Review-Url: https://codereview.chromium.org/2973643002 Cr-Commit-Position: refs/heads/master@{#484932} Committed: https://chromium.googlesource.com/chromium/src/+/7933c57f94e3cedbfdbda3e61b55ede90ef2dac5

Patch Set 1 #

Patch Set 2 : Add a TODO #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M content/browser/renderer_host/render_process_host_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Guido Urdaneta
lgtm +jochen@ for OWNERS review
3 years, 5 months ago (2017-07-05 14:13:05 UTC) #2
jochen (gone - plz use gerrit)
can you add a test please?
3 years, 5 months ago (2017-07-06 14:58:32 UTC) #4
jochen (gone - plz use gerrit)
lgtm with a TODO to add a test once you're back
3 years, 5 months ago (2017-07-07 14:06:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2973643002/20001
3 years, 5 months ago (2017-07-07 14:24:36 UTC) #8
commit-bot: I haz the power
3 years, 5 months ago (2017-07-07 15:22:47 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/7933c57f94e3cedbfdbda3e61b55...

Powered by Google App Engine
This is Rietveld 408576698