Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(601)

Issue 2973593002: Revert of Set the current context to the function's context when entering to LAP. (Closed)

Created:
3 years, 5 months ago by Michael Achenbach
Modified:
3 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Set the current context to the function's context when entering to LAP. (patchset #14 id:540001 of https://codereview.chromium.org/2770003002/ ) Reason for revert: Speculative: Seems to break webkit_unit_tests: https://build.chromium.org/p/tryserver.v8/builders/v8_linux_blink_rel/builds/23247 https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Mac/builds/11038 Original issue's description: > Set the current context to the function's context when entering to LAP. > > In case of LAP(lazy accessor pair), the function's creation context > must be equal to the accessor holder's creation context, so this CL > changes the current context to the accessor holder's creation context. > > BUG=v8:6156 > > Review-Url: https://codereview.chromium.org/2770003002 > Cr-Commit-Position: refs/heads/master@{#46406} > Committed: https://chromium.googlesource.com/v8/v8/+/18e73287dc65452bc2f952fc005b2251fc32c15a TBR=jochen@chromium.org,verwaest@chromium.org,mstarzinger@chromium.org,tebbi@google.com,yukishiino@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:6156 Review-Url: https://codereview.chromium.org/2973593002 Cr-Commit-Position: refs/heads/master@{#46408} Committed: https://chromium.googlesource.com/v8/v8/+/653f43d579f0d41767a7f2d90dde1246e6a2d23c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -272 lines) Patch
M src/arm/code-stubs-arm.cc View 4 chunks +10 lines, -18 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 3 chunks +13 lines, -21 lines 0 comments Download
M src/compiler/js-call-reducer.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M src/compiler/js-native-context-specialization.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/js-native-context-specialization.cc View 6 chunks +11 lines, -17 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 3 chunks +11 lines, -18 lines 0 comments Download
M src/ic/arm/handler-compiler-arm.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/ic/arm64/handler-compiler-arm64.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/ic/ia32/handler-compiler-ia32.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/ic/mips/handler-compiler-mips.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/ic/mips64/handler-compiler-mips64.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/ic/ppc/handler-compiler-ppc.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/ic/s390/handler-compiler-s390.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/ic/x64/handler-compiler-x64.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ic/x87/handler-compiler-x87.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/mips/code-stubs-mips.cc View 4 chunks +8 lines, -17 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 4 chunks +9 lines, -18 lines 0 comments Download
M src/objects.cc View 4 chunks +2 lines, -6 lines 0 comments Download
M src/ppc/code-stubs-ppc.cc View 4 chunks +10 lines, -17 lines 0 comments Download
M src/s390/code-stubs-s390.cc View 4 chunks +11 lines, -18 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 4 chunks +11 lines, -18 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 3 chunks +11 lines, -18 lines 0 comments Download
M test/unittests/api/v8-object-unittest.cc View 2 chunks +0 lines, -71 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Michael Achenbach
Created Revert of Set the current context to the function's context when entering to LAP.
3 years, 5 months ago (2017-07-05 10:41:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2973593002/1
3 years, 5 months ago (2017-07-05 10:41:13 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/v8/v8/+/653f43d579f0d41767a7f2d90dde1246e6a2d23c
3 years, 5 months ago (2017-07-05 10:41:33 UTC) #6
Yuki
3 years, 5 months ago (2017-07-05 12:01:26 UTC) #7
Message was sent while issue was closed.
LGTM for revert.

Probably, Blink's tests would be wrong (Blink's tests now depend on the wrong
implementation of the current context).  I'll take a look.

Powered by Google App Engine
This is Rietveld 408576698