Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 2973583002: Get rid of SelectionTemplate::has_trailing_whitespace_ (Closed)

Created:
3 years, 5 months ago by yosin_UTC9
Modified:
3 years, 5 months ago
Reviewers:
yoichio
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Get rid of SelectionTemplate::has_trailing_whitespace_ This patch gets rid of redundant member variable |has_trailing_whitespace_| from |SelectionTemplate| for improving code health, since the patch[1], nobody sets this member variable true, [1] http://crrev.com/2966433002: Get rid of VisibleSelectionTemplate::has_trailing_whitespace_ BUG=692923 TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2973583002 Cr-Commit-Position: refs/heads/master@{#484239} Committed: https://chromium.googlesource.com/chromium/src/+/a9d878d2268ec9db32e6f682c96bfe3cf93a1f4e

Patch Set 1 : 2017-07-05T15:40:09 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -22 lines) Patch
M third_party/WebKit/Source/core/editing/FrameSelection.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/SelectionEditor.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/SelectionTemplate.h View 3 chunks +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/editing/SelectionTemplate.cpp View 4 chunks +0 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/editing/SelectionTemplateTest.cpp View 3 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
yosin_UTC9
PTAL
3 years, 5 months ago (2017-07-05 07:49:55 UTC) #6
yoichio
lgtm
3 years, 5 months ago (2017-07-05 08:45:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2973583002/1
3 years, 5 months ago (2017-07-05 08:57:01 UTC) #10
commit-bot: I haz the power
3 years, 5 months ago (2017-07-05 11:02:37 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a9d878d2268ec9db32e6f682c96b...

Powered by Google App Engine
This is Rietveld 408576698