MacViews: Don't InsertChar() for consumed events.

ui/views/cocoa/bridged_content_view.mm

Index: ui/views/cocoa/bridged_content_view.mm
diff --git a/ui/views/cocoa/bridged_content_view.mm b/ui/views/cocoa/bridged_content_view.mm
index 46e34d86737b6a9716db18835ad7ea1b38f59c4d..e300b7e245c66c6c540e10f4df6ee48ca84dfd88 100644
--- a/ui/views/cocoa/bridged_content_view.mm
+++ b/ui/views/cocoa/bridged_content_view.mm
@@ -530,6 +530,8 @@ ui::TextEditCommand GetTextEditCommandForMenuAction(SEL action) {
                            ui::EF_NONE);
     [self handleKeyEvent:&charEvent];
     hasUnhandledKeyDownEvent_ = NO;
+    if (charEvent.handled())

[msw, 2017/07/05 19:21:21]

q: Should this actually be in the |isCharacterEvent && ![self hasMarkedText]|
conditional, or should other previously-handled key events also early return?

[tapted, 2017/07/06 05:58:07]

This one is a special case. The |charEvent| that gets handled only exists within
the scope of the (|isCharacterEvent && ![self hasMarkedText]|) conditional, so
the check for early return must be here.  It's special because on Mac we need to
handle actions from non-accelerator events such as VKEY_SPACE inside a handler
for [.. insertText:@" "] so that IME first gets a chance to handle it (see long
comment above :).

suppression of handled key events in other places happens via
hasUnhandledKeyDownEvent_, but we can't do that here because the unhandled
KeyDown we track doesn't have all the information on it (i.e. the full string),
which we need later in this method.

+      return;
   }
 
   // Forward the |text| to |textInputClient_| if no menu is active.