MacViews: Don't InsertChar() for consumed events.

ui/views/cocoa/bridged_content_view.mm

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ui/views/cocoa/bridged_content_view.h"
 
 #include "base/logging.h"
 #import "base/mac/mac_util.h"
 #import "base/mac/scoped_nsobject.h"
 #import "base/mac/sdk_forward_declarations.h"
@@ skipping 512 matching lines @@
   // marked text. However, a KeyEvent will be generated corresponding to 'r'.
 
   // Currently there seems to be no use case to pass non-character events routed
   // from insertText: handlers to the View hierarchy.
   if (isCharacterEvent && ![self hasMarkedText]) {
     ui::KeyEvent charEvent([text characterAtIndex:0],
                            ui::KeyboardCodeFromNSEvent(keyDownEvent_),
                            ui::EF_NONE);
     [self handleKeyEvent:&charEvent];
     hasUnhandledKeyDownEvent_ = NO;
+    if (charEvent.handled())

[msw, 2017/07/05 19:21:21]

q: Should this actually be in the |isCharacterEvent && ![self hasMarkedText]|
conditional, or should other previously-handled key events also early return?

[tapted, 2017/07/06 05:58:07]

This one is a special case. The |charEvent| that gets handled only exists within
the scope of the (|isCharacterEvent && ![self hasMarkedText]|) conditional, so
the check for early return must be here.  It's special because on Mac we need to
handle actions from non-accelerator events such as VKEY_SPACE inside a handler
for [.. insertText:@" "] so that IME first gets a chance to handle it (see long
comment above :).

suppression of handled key events in other places happens via
hasUnhandledKeyDownEvent_, but we can't do that here because the unhandled
KeyDown we track doesn't have all the information on it (i.e. the full string),
which we need later in this method.

+      return;
   }
 
   // Forward the |text| to |textInputClient_| if no menu is active.
   if (textInputClient_ && ![self activeMenuController]) {
     // If a single character is inserted by keyDown's call to
     // interpretKeyEvents: then use InsertChar() to allow editing events to be
     // merged. We use ui::VKEY_UNKNOWN as the key code since it's not feasible
     // to determine the correct key code for each unicode character. Also a
     // correct keycode is not needed in the current context. Send ui::EF_NONE as
     // the key modifier since |text| already accounts for the pressed key
@@ skipping 975 matching lines @@
   return [hostedView_->GetNativeViewAccessible() accessibilityHitTest:point];
 }
 
 - (id)accessibilityFocusedUIElement {
   if (!hostedView_)
     return nil;
   return [hostedView_->GetNativeViewAccessible() accessibilityFocusedUIElement];
 }
 
 @end