Block redirects to renderer-debug urls.

content/browser/child_process_security_policy_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/child_process_security_policy_impl.h"
 
 #include <algorithm>
 #include <utility>
 
 #include "base/command_line.h"
@@ skipping 649 matching lines @@
 
   // If the process can commit the URL, it can request it.
   if (CanCommitURL(child_id, url))
     return true;
 
   // Also allow URLs destined for ShellExecute and not the browser itself.
   return !GetContentClient()->browser()->IsHandledURL(url) &&
          !net::URLRequest::IsHandledURL(url);
 }
 
+bool ChildProcessSecurityPolicyImpl::CanRedirectToURL(const GURL& url) {
+  if (!url.is_valid())
+    return false;  // Can't redirect to invalid URLs.
+
+  if (IsPseudoScheme(url.scheme())) {

[Charlie Harrison, 2017/07/05 13:52:31]

nit:
const std::string& scheme = url.scheme() and use it below, to avoid a copy.

[arthursonzogni, 2017/07/05 14:52:19]

In this case, for consistency, the same thing should be done in a few similar
places in this file.
I will apply your suggestion everywhere, but in order not to pollute this CL, it
will be in a separate CL.
Please see: https://codereview.chromium.org/2966203002

+    // Redirects to a pseudo scheme (about, javascript, view-source, ...) are
+    // not allowed. An exception is made for <about:blank> and its variations.
+    return url.IsAboutBlank();
+  }
+
+  // Redirects to blob-url or filesystem-url are not allowed.
+  if (url.SchemeIsBlob() || url.SchemeIsFileSystem())
+    return false;
+
+  return IsWebSafeScheme(url.scheme());
+}
+
 bool ChildProcessSecurityPolicyImpl::CanCommitURL(int child_id,
                                                   const GURL& url) {
   if (!url.is_valid())
     return false;  // Can't commit invalid URLs.
 
   // Of all the pseudo schemes, only about:blank and about:srcdoc are allowed to
   // commit.
   if (IsPseudoScheme(url.scheme()))
     return url == url::kAboutBlankURL || url == kAboutSrcDocURL;
 
@@ skipping 463 matching lines @@
   return found;
 }
 
 void ChildProcessSecurityPolicyImpl::RemoveIsolatedOriginForTesting(
     const url::Origin& origin) {
   base::AutoLock lock(lock_);
   isolated_origins_.erase(origin);
 }
 
 }  // namespace content