Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Issue 2966203002: Avoid string copy of url.scheme() in ChildProcessSecurityPolicyImpl. (Closed)

Created:
3 years, 5 months ago by arthursonzogni
Modified:
3 years, 5 months ago
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid string copy of url.scheme() in ChildProcessSecurityPolicyImpl. In every method of ChildProcessSecurityPolicyImpl, this CL makes url.scheme() being called only once. BUG=None Review-Url: https://codereview.chromium.org/2966203002 Cr-Commit-Position: refs/heads/master@{#485095} Committed: https://chromium.googlesource.com/chromium/src/+/669158e6acfd160a5a5ada8c12c43ef22016d1cb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -12 lines) Patch
M content/browser/child_process_security_policy_impl.cc View 8 chunks +19 lines, -12 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
arthursonzogni
Hi csharrison@ and creis@ Could you please review this? csharrisson@ -> This is the nit ...
3 years, 5 months ago (2017-07-05 14:41:45 UTC) #5
Charlie Harrison
LGTM thanks for the followup.
3 years, 5 months ago (2017-07-05 16:49:28 UTC) #8
Charlie Reis
Thanks! LGTM.
3 years, 5 months ago (2017-07-07 22:09:08 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2966203002/1
3 years, 5 months ago (2017-07-07 22:09:46 UTC) #11
commit-bot: I haz the power
3 years, 5 months ago (2017-07-07 23:22:42 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/669158e6acfd160a5a5ada8c12c4...

Powered by Google App Engine
This is Rietveld 408576698