Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Unified Diff: dart/tests/html/xhr_test.dart

Issue 297343005: Don't expect anything about 404 responseText (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/tests/html/xhr_test.dart
diff --git a/dart/tests/html/xhr_test.dart b/dart/tests/html/xhr_test.dart
index d4755291ae82dad5b31252e73b2afb1d816c52f1..5759222e52866304686dbffa41b1454e8b171b91 100644
--- a/dart/tests/html/xhr_test.dart
+++ b/dart/tests/html/xhr_test.dart
@@ -28,7 +28,10 @@ main() {
void validate404(xhr) {
expect(xhr.status, equals(404));
- expect(xhr.responseText, equals(''));
+ // We cannot say much about xhr.responseText, most HTTP servers will
Emily Fortuna 2014/05/27 15:55:35 Don't we know that the response text is always ''
ahe 2014/05/27 15:59:10 One might think that, but I just changed it to inc
+ // include an HTML page explaining the error to a human.
+ String responseText = xhr.responseText;
+ expect(responseText, isNotNull);
}
group('supported_onProgress', () {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698