Don't expect anything about 404 responseText

dart/tests/html/xhr_test.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library XHRTest;
 import 'dart:async';
 import 'dart:convert';
 import 'dart:html';
 import 'dart:typed_data';
 import 'package:unittest/html_individual_config.dart';
@@ skipping 10 matching lines @@
   void validate200Response(xhr) {
     expect(xhr.status, equals(200));
     var data = JSON.decode(xhr.responseText);
     expect(data, contains('feed'));
     expect(data['feed'], contains('entry'));
     expect(data, isMap);
   }
 
   void validate404(xhr) {
     expect(xhr.status, equals(404));
-    expect(xhr.responseText, equals(''));
+    // We cannot say much about xhr.responseText, most HTTP servers will

[Emily Fortuna, 2014/05/27 15:55:35]

Don't we know that the response text is always '' since we're using our own dart
test server, though?

[ahe, 2014/05/27 15:59:10]

One might think that, but I just changed it to include a message. Mostly to work
around https://bugzilla.mozilla.org/show_bug.cgi?id=1016313.

+    // include an HTML page explaining the error to a human.
+    String responseText = xhr.responseText;
+    expect(responseText, isNotNull);
   }
 
   group('supported_onProgress', () {
     test('supported', () {
       expect(HttpRequest.supportsProgressEvent, isTrue);
     });
   });
 
   group('supported_onLoadEnd', () {
     test('supported', () {
@@ skipping 204 matching lines @@
       return HttpRequest.request(url).then(
         (xhr) {
           var serverHeader = xhr.responseHeaders['server'];
           expect(serverHeader, isNotNull);
           // Should be like: 'Dart/0.1 (dart:io)'
           expect(serverHeader.startsWith('Dart/'), isTrue);
         });
     });
   });
 }