Issue 297343003: Fix for the input element contains extra '\t' TAB symbol after pressing TAB key when JS pop-up is a…

Created:
6 years, 7 months ago by chhajer.m

Modified:
6 years, 5 months ago

Reviewers:
tkent, eseidel

CC:
blink-reviews, yosin_UTC9

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Fix for the input element contains extra '\t' TAB symbol after pressing TAB key when JS pop-up is associated with it.For the cases where java script is making a synchronus communication with other process (Like browser process for alert/confirm messages pop-up), it is making process to stop execution of the current event(Message) but to keep UI responsive renderer process is continuing handling of the other queued messages. Which means before the key event with type= RawKeyDown mark the m_suppressNextKeypressEvent flag true because of javascript has blocked the execution of thecurrent event with the synchronus message call to other process/thread, but renderer is continuing hadling the next messages form which one is keypress event which comes with event typr = char and insertion of the "\t". So to avoid this I am setting the m_suppressNextKeypressEvent flag true before javascript is making the synchronus call to other process. BUG=364040

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Added layout tests. #

Total comments: 6

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+60 lines, -9 lines)			Patch
A	LayoutTests/fast/forms/text-input-js-pop-up-for-tab-pressed.html	View	1 2	1 chunk	+36 lines, -0 lines	6 comments	Download
A	LayoutTests/fast/forms/text-input-js-pop-up-for-tab-pressed-expected.txt	View	1 2	1 chunk	+12 lines, -0 lines	0 comments	Download
M	Source/web/WebViewImpl.cpp	View	1 2	1 chunk	+12 lines, -9 lines	0 comments	Download

Messages

Total messages: 10 (0 generated)

Expand Messages | Collapse Messages

chhajer.m

I have submitted a patch for issue. From my local testing it is fixing the ...

6 years, 6 months ago (2014-06-19 05:32:55 UTC) #3

tkent

I'm not familiar with this code. eseidel, you touched code around it four years ago. ...

6 years, 6 months ago (2014-06-19 08:52:08 UTC) #4

eseidel

I suspect it wasn't actually me who touched it, but rather the webkit commit-queue running ...

6 years, 6 months ago (2014-06-24 23:47:35 UTC) #5

chhajer.m

On 2014/06/24 23:47:35, eseidel wrote: > I suspect it wasn't actually me who touched it, ...

6 years, 5 months ago (2014-07-08 13:20:31 UTC) #6

chhajer.m

On 2014/06/24 23:47:35, eseidel wrote: > I suspect it wasn't actually me who touched it, ...

6 years, 5 months ago (2014-07-08 13:54:01 UTC) #7

eseidel

Here is some documentation on LayoutTests: http://trac.webkit.org/wiki/Writing%20Layout%20Tests%20for%20DumpRenderTree http://www.chromium.org/developers/testing/webkit-layout-tests https://codereview.chromium.org/297343003/diff/40001/LayoutTests/fast/forms/text-input-js-pop-up-for-tab-pressed.html File LayoutTests/fast/forms/text-input-js-pop-up-for-tab-pressed.html (right): https://codereview.chromium.org/297343003/diff/40001/LayoutTests/fast/forms/text-input-js-pop-up-for-tab-pressed.html#newcode5 LayoutTests/fast/forms/text-input-js-pop-up-for-tab-pressed.html:5: function ...

6 years, 5 months ago (2014-07-08 15:43:08 UTC) #8

eseidel

6 years, 5 months ago (2014-07-08 15:43:09 UTC) #9

eseidel

6 years, 5 months ago (2014-07-08 15:43:40 UTC) #10

I would also encourage you to reach out to any of your experiance webkit/blink
colleagues who might be able to help you write a test/patch.

Thanks.

Expand Messages | Collapse Messages