LayoutTests/fast/forms/text-input-js-pop-up-for-tab-pressed.html - Issue 297343003: Fix for the input element contains extra '\t' TAB symbol after pressing TAB key when JS pop-up is a…

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/forms/text-input-js-pop-up-for-tab-pressed.html

Issue 297343003: Fix for the input element contains extra '\t' TAB symbol after pressing TAB key when JS pop-up is a… Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Added layout tests. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <script>

	5 function myfunction(e) {
	eseidel 2014/07/08 15:43:08 Do we have a more descriptive name than myFunction Do we have a more descriptive name than myFunction?
	6 if(e.which == 9 )
	eseidel 2014/07/08 15:43:08 Why the inconsistent spacing? Why the inconsistent spacing?
	7 alert(document.getElementById('text1').value);
	eseidel 2014/07/08 15:43:08 Why alert here if you have a shouldBe below? Why alert here if you have a shouldBe below?
	8 testRunner.notifyDone();
	eseidel 2014/07/08 15:43:08 This isn't a waitUntilDone test, you don't need no This isn't a waitUntilDone test, you don't need notifyDone.
	9 }

	10 </script>

	11 <script src="../../resources/js-test.js"></script>

	12 </head>

	13 <body>

	14 <form id=parent>

	15 <input type="text" id="text1" onkeydown="myfunction(event)", value="abcd" >

	16 <input type="text" id="text2" >
	eseidel 2014/07/08 15:43:08 Why all the funny spacing after the last attribute Why all the funny spacing after the last attribute?
	17 <input type="text" id="text3" >

	18 <input type="text" id="text4" onkeydown="myfunction(event)" >

	19 </form>

	20 <script>

	21 text1.focus();

	22 if (window.testRunner) {

	23 debug("This test case checks when we press a tab key in a text field ins erts tab in the text field when there is JS pop-up associated with the texbox fo r tab press event,");
	eseidel 2014/07/08 15:43:08 The helper you are using has a description() metho The helper you are using has a description() method which can take this kind of explanation for you and put it in the right place.
	24 debug("which actually should not insert tab in the text field.");

	25 debug("\nTo test this manully write a sample page which has textbox and js pop-up(alert or confirmation) for tab keypress event, then focus on the textb ox and press tab, see there is a tab inserted or not in the textbox.");

	26 debug("\n");

	27 eventSender.keyDown('\t');

	28 var expectedValue="abcd";

	29 shouldBe("document.getElementById('text1').value", "expectedValue");

	30 debug(document.getElementById('text2').value);

	31 }

	32 </script>

	33

	34 </body>

	35 </html>

	36

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/forms/text-input-js-pop-up-for-tab-pressed-expected.txt » ('j') | no next file with comments »