Chromium Code Reviews Chromium Code Reviews
Issue
2973313002:
Chrome Cleanup: re-open settings post-cleanup if reboot is needed (Closed)
DescriptionChrome Cleanup: re-open settings post-cleanup if reboot is needed
Once the user has accepted cleanup, the cleaner runs for a few minutes
and eventually terminates with exit codes 0 (success) or 15 (reboot
required).
If a reboot is required, we would like the user to reboot their machine
as soon as possible. However, opening a new foreground tab has issues
such as putting settings option where the user was clicking on their
original page. To be safe, we use a new background tab so the user can
eventually get to it.
We don't open a new tab if the current tab is chrome://settings since
most* users will be able to see the call to reboot.
*: Users who have scrolled down the page may not see the prompt if they
don't scroll back up. I don't think we want to refresh or scroll up the
page in case they were modifying another setting.
Known issue: users that had a settings tab opened prior to the transition
to kInfected and are on that old tab instead of a more recent settings
tab may not see the call to reboot.
BUG=690020
Review-Url: https://codereview.chromium.org/2973313002
Cr-Commit-Position: refs/heads/master@{#486102}
Committed: https://chromium.googlesource.com/chromium/src/+/e1324a6252e368ed1b6fb5eb9dcfe77a203bbee2
Patch Set 1 #Patch Set 2 : add line break #Patch Set 3 : Revert changes to md_settings_ui.cc (to do in another CL) #
Total comments: 9
Patch Set 4 : Address review comments on #3 #
Total comments: 6
Patch Set 5 : Address review commenst on #4 #Patch Set 6 : Rebase #Patch Set 7 : navigation_util -> navigation_util_win since not used on other platforms #
Messages
Total messages: 34 (16 generated)
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||
