Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Unified Diff: content/browser/background_fetch/background_fetch_event_dispatcher.cc

Issue 2973233002: [Background Fetch] Cleanup/fix thread safety (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/background_fetch/background_fetch_event_dispatcher.cc
diff --git a/content/browser/background_fetch/background_fetch_event_dispatcher.cc b/content/browser/background_fetch/background_fetch_event_dispatcher.cc
index 291a19dc45ddaa35f17a40eab3c238d189c0eb9c..5a04c622c8918af14c54a8d24f5595ccf744e123 100644
--- a/content/browser/background_fetch/background_fetch_event_dispatcher.cc
+++ b/content/browser/background_fetch/background_fetch_event_dispatcher.cc
@@ -67,7 +67,9 @@ BackgroundFetchEventDispatcher::BackgroundFetchEventDispatcher(
const scoped_refptr<ServiceWorkerContextWrapper>& service_worker_context)
: service_worker_context_(service_worker_context) {}
-BackgroundFetchEventDispatcher::~BackgroundFetchEventDispatcher() = default;
+BackgroundFetchEventDispatcher::~BackgroundFetchEventDispatcher() {
+ DCHECK_CURRENTLY_ON(BrowserThread::IO);
Peter Beverloo 2017/07/10 13:13:21 Please add a DCHECK_CURRENTLY_ON to the constructo
johnme 2017/07/10 13:41:07 Done here; the header already says "Must only be u
+}
void BackgroundFetchEventDispatcher::DispatchBackgroundFetchAbortEvent(
const BackgroundFetchRegistrationId& registration_id,

Powered by Google App Engine
This is Rietveld 408576698