[Background Fetch] Cleanup/fix thread safety

content/browser/background_fetch/background_fetch_event_dispatcher.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/background_fetch/background_fetch_event_dispatcher.h"
 
 #include "base/bind.h"
 #include "base/callback.h"
 #include "base/metrics/histogram_functions.h"
 #include "base/strings/stringprintf.h"
@@ skipping 49 matching lines @@
   base::UmaHistogramEnumeration(histogram_name, service_worker_status,
                                 SERVICE_WORKER_ERROR_MAX_VALUE);
 }
 
 }  // namespace
 
 BackgroundFetchEventDispatcher::BackgroundFetchEventDispatcher(
     const scoped_refptr<ServiceWorkerContextWrapper>& service_worker_context)
     : service_worker_context_(service_worker_context) {}
 
-BackgroundFetchEventDispatcher::~BackgroundFetchEventDispatcher() = default;
+BackgroundFetchEventDispatcher::~BackgroundFetchEventDispatcher() {
+  DCHECK_CURRENTLY_ON(BrowserThread::IO);

[Peter Beverloo, 2017/07/10 13:13:21]

Please add a DCHECK_CURRENTLY_ON to the constructor as well, since that'll
happen on UI. Would be worthwhile to document its threading model in the header
file too.

[johnme, 2017/07/10 13:41:07]

Done here; the header already says "Must only be used on the IO thread."

+}
 
 void BackgroundFetchEventDispatcher::DispatchBackgroundFetchAbortEvent(
     const BackgroundFetchRegistrationId& registration_id,
     base::Closure finished_closure) {
   DCHECK_CURRENTLY_ON(BrowserThread::IO);
   LoadServiceWorkerRegistrationForDispatch(
       registration_id, ServiceWorkerMetrics::EventType::BACKGROUND_FETCH_ABORT,
       std::move(finished_closure),
       base::Bind(
           &BackgroundFetchEventDispatcher::DoDispatchBackgroundFetchAbortEvent,
@@ skipping 153 matching lines @@
       } else {
         RecordDispatchResult(event, DISPATCH_RESULT_SUCCESS);
       }
       break;
   }
 
   finished_closure.Run();
 }
 
 }  // namespace content