Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 2973133002: [file] fix glob_paths when NO paths match, add tests. (Closed)

Created:
3 years, 5 months ago by iannucci
Modified:
3 years, 5 months ago
Reviewers:
dnj
CC:
chromium-reviews, infra-reviews+recipes-py_chromium.org, npm, dsinclair
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+160 lines, -1 line) Patch
M README.recipes.md View 2 chunks +6 lines, -0 lines 0 comments Download
M recipe_engine/unittests/run_test.py View 1 chunk +1 line, -0 lines 0 comments Download
A recipe_modules/file/examples/glob.py View 1 chunk +29 lines, -0 lines 0 comments Download
A recipe_modules/file/examples/glob.expected/basic.json View 1 chunk +121 lines, -0 lines 0 comments Download
M recipe_modules/file/resources/fileutil.py View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 11 (7 generated)
iannucci
3 years, 5 months ago (2017-07-06 20:25:24 UTC) #1
dnj
lgtm
3 years, 5 months ago (2017-07-06 20:26:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2973133002/1
3 years, 5 months ago (2017-07-06 20:26:37 UTC) #7
commit-bot: I haz the power
3 years, 5 months ago (2017-07-06 20:29:55 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/recipes-py/commit/241ddc299faa009b8842f95d40fdd7760b8...

Powered by Google App Engine
This is Rietveld 408576698